Bug 188670

Summary: [patch] update devel/seed (2.31.91) to build with both new and older readline
Product: Ports & Packages Reporter: John Hein <john.hein>
Component: Individual Port(s)Assignee: freebsd-gnome (Nobody) <gnome>
Status: Closed FIXED    
Severity: Affects Only Me CC: gnome
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description John Hein 2014-04-15 20:20:00 UTC 
If the devel/readline (6.3+) port is installed, you can get build
errors with devel/seed (currently 2.31.91_4).

gmake[3]: Entering directory `/d/pub/jhein/.no-amanda-backup/wd/usr/ports/devel/seed/work/seed-2.31.91/modules/readline'
  CC     libseed_readline_la-seed-readline.lo
seed-readline.c: In function 'seed_readline_bind':
seed-readline.c:80: error: 'Function' undeclared (first use in this function)
seed-readline.c:80: error: (Each undeclared identifier is reported only once
seed-readline.c:80: error: for each function it appears in.)
seed-readline.c:80: error: expected expression before ')' token

How-To-Repeat: 
install devel/readline (6.3.3)
try to build devel/seed (2.31.91_4)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-15 20:20:04 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-04-29 22:05:48 UTC 
Author: kwm
Date: Tue Apr 29 21:05:43 2014
New Revision: 352643
URL: http://svnweb.freebsd.org/changeset/ports/352643
QAT: https://qat.redports.org/buildarchive/r352643/

Log:
  Fix the build with readline from ports.
  
  PR:		ports/188670 [1]
  		ports/187883 [2]
  Submitted by:	John Hein <john.hein@microsemi.com> [1]
  		truckman@

Added:
  head/devel/seed/files/patch-modules_readline_seed-readline.c   (contents, props changed)

Added: head/devel/seed/files/patch-modules_readline_seed-readline.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/devel/seed/files/patch-modules_readline_seed-readline.c	Tue Apr 29 21:05:43 2014	(r352643)
@@ -0,0 +1,15 @@
+'Function' is deprecated - patch to work with older readline API
+(e.g., currently in base) or new (e.g., readline 6.3.3 in ports).
+
+http://lists.gnu.org/archive/html/bug-readline/2014-03/msg00002.html
+
+--- modules/readline/seed-readline.c.orig	2010-08-30 15:37:39.000000000 -0600
++++ modules/readline/seed-readline.c	2014-04-15 13:00:13.000000000 -0600
+@@ -77,7 +77,7 @@
+   key = seed_value_to_string(ctx, arguments[0], exception);
+   c = seed_make_rl_closure((SeedObject) arguments[1]);
+ 
+-  rl_bind_key(*key, (Function *) c);
++  rl_bind_key(*key, (rl_command_func_t *) c);
+ 
+   g_free(key);
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Koop Mast freebsd_committer freebsd_triage 2014-04-29 22:06:18 UTC 
State Changed
From-To: open->closed

Committed thanks