Bug 188675

Summary: [PATCH] sysutils/puppet: Silence ruby19+ warning
Product: Ports & Packages Reporter: Mathieu Arnold <mat>
Component: Individual Port(s)Assignee: Steve Wills <swills>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
puppet-3.4.3.patch none

Description Mathieu Arnold freebsd_committer freebsd_triage 2014-04-15 23:30:00 UTC 
Starting with ruby 1.9.2, setting a class variable from the class emmits a warning:
/usr/local/lib/ruby/site_ruby/1.9/puppet/provider/package/freebsd.rb:18: warning: class variable access from toplevel
/usr/local/lib/ruby/site_ruby/1.9/puppet/provider/package/freebsd.rb:19: warning: class variable access from toplevel

This is the way it is silenced (it is silly, yes, but it is how it is.)

Generated with FreeBSD Port Tools 1.01 (mode: change, diff: SVN)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-04-15 23:30:03 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->swills

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-04-16 14:45:13 UTC 
Author: swills
Date: Wed Apr 16 13:45:10 2014
New Revision: 351385
URL: http://svnweb.freebsd.org/changeset/ports/351385
QAT: https://qat.redports.org/buildarchive/r351385/

Log:
  - Fix warning in pkg provider
  
  PR:		ports/184005 [1]
  PR:		ports/188675 [2]
  Submitted by:	Tristan Smith <tsmith@palantir.com> [1]
  Submitted by:	Mathieu Arnold <mat@freebsd.org> [2]

Modified:
  head/sysutils/puppet/Makefile
  head/sysutils/puppet/files/optpatch-package_origin

Modified: head/sysutils/puppet/Makefile
==============================================================================
--- head/sysutils/puppet/Makefile	Wed Apr 16 13:40:14 2014	(r351384)
+++ head/sysutils/puppet/Makefile	Wed Apr 16 13:45:10 2014	(r351385)
@@ -3,6 +3,7 @@
 
 PORTNAME=	puppet
 PORTVERSION=	3.4.3
+PORTREVISION=	1
 CATEGORIES=	sysutils
 MASTER_SITES=	http://downloads.puppetlabs.com/puppet/
 

Modified: head/sysutils/puppet/files/optpatch-package_origin
==============================================================================
--- head/sysutils/puppet/files/optpatch-package_origin	Wed Apr 16 13:40:14 2014	(r351384)
+++ head/sysutils/puppet/files/optpatch-package_origin	Wed Apr 16 13:45:10 2014	(r351385)
@@ -30,8 +30,8 @@
  
 -  def self.listcmd
 -    command(:pkginfo)
-+  @@lock = Mutex.new
-+  @@ports_index = nil
++  class_variable_set(:@@lock, Mutex.new)
++  class_variable_set(:@@ports_index, nil)
 +
 +  # fix bug in URI::FTP merge method that tries to set typecode
 +  # even when other is a string.
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Steve Wills freebsd_committer freebsd_triage 2014-04-16 14:45:16 UTC 
State Changed
From-To: open->closed

Committed. Thanks!