Summary: | [NEW PORT] japanese/latex-jlisting: Enhancement of lstlisting environment for handling Japanese text | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | hiroto.kagotani | ||||||||||
Component: | Individual Port(s) | Assignee: | John Marino <marino> | ||||||||||
Status: | Closed FIXED | ||||||||||||
Severity: | Affects Only Me | CC: | marino | ||||||||||
Priority: | Normal | ||||||||||||
Version: | Latest | ||||||||||||
Hardware: | Any | ||||||||||||
OS: | Any | ||||||||||||
Attachments: |
|
Description
hiroto.kagotani
2014-04-16 14:50:02 UTC
Is this port still valid after all those latex ports were removed recently? quick review of shar: use "NO_BUILD=yes" instead of empty "do-build:" target don't have post-install target with do-install target, just merge them to do-install. change "EXTRACT_SUFX= .bz2" to "USES+= tar:bz2" The post-install target looks very suspicious especially since it will not be run by package (you need a post-install script for that. But I don't know what it is supposed to do... So even if the port is still valid, it needs another iteration and poudriere test logs (either "testport" or "bulk -t") would be nice too. Created attachment 146667 [details] shar file Thank you very much for comments. I updated and cleaned-up the port as the attached new shar file. I also attach some log files. Redport log can be found at https://redports.org/buildarchive/20140902081114-24629/ Regards, Created attachment 146668 [details]
"poudriere testport -j 100amd64 -o japanese/latex-jlisting" output
Created attachment 146669 [details]
"portlint -AC" output
> change "EXTRACT_SUFX= .bz2" to "USES+= tar:bz2"
That is not the case, because the distfile is not a tar'ed file -
just a bzipped plain file named jlisting.sty.bz2.
Thanks.
ok, thanks for the update. I'm moving this to "patch-ready" pool. A commit references this bug: Author: marino Date: Sat Sep 20 15:28:03 UTC 2014 New revision: 368649 URL: http://svnweb.freebsd.org/changeset/ports/368649 Log: Add new port japanese/latex-jlisting PR: 188691 Submitted by: Hiroto Kagotani jlisting.sty enhances lstlisting environment provided by listings.sty for handling Japanese text. Changes: head/japanese/Makefile head/japanese/latex-jlisting/ head/japanese/latex-jlisting/Makefile head/japanese/latex-jlisting/distinfo head/japanese/latex-jlisting/pkg-descr Okay, I made some changes, the most notable one is eliminating the pkg-plist file. I also stopped using $DISTNAME in the do-install target, which was necessary after removing the DISTNAME and WRKSRC definitions. There were other minor tweaks done as well, but it passes poudriere cleanly. |