Bug 188808

Summary: New port: science/sigrok-firmware-utils
Product: Ports & Packages Reporter: Uffe Jakobsen <uffe>
Component: Individual Port(s)Assignee: John Marino <marino>
Status: Closed FIXED    
Severity: Affects Only Me CC: marino
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 188810    
Attachments:
Description Flags
file.shar
none
sigrok-firmware-utils.shar.txt
none
sigrok-firmware-utils-20140418.log none

Description Uffe Jakobsen 2014-04-19 23:10:00 UTC
New port: science/sigrok-firmware-utils

firmware extraction utils port/package for the existing sigrok ports

PS: these utils are not yet versioned by the sigrok project - and hence embedded into the files dir until a official release is made by the sigrok project.

Fix: Patch attached with submission follows:
Comment 1 Uffe Jakobsen 2014-07-22 20:30:47 UTC
Any news after 3 months ?
Comment 2 John Marino freebsd_committer freebsd_triage 2014-07-28 06:27:40 UTC
it supports stage.
Comment 3 John Marino freebsd_committer freebsd_triage 2014-07-31 22:31:05 UTC
test logs please (see bug 179854)
Comment 4 Uffe Jakobsen 2014-08-03 01:51:40 UTC
Created attachment 145280 [details]
sigrok-firmware-utils.shar.txt
Comment 5 Uffe Jakobsen 2014-08-03 01:52:00 UTC
Created attachment 145281 [details]
sigrok-firmware-utils-20140418.log
Comment 6 Uffe Jakobsen 2014-08-03 01:53:00 UTC
Web rebuild
---------------------------------------------------------------------

  Build ID:          20140803002531-77129
  Job owner:         uffe
  Buildtime:         29 minutes
  Enddate:           Sun, 03 Aug 2014 00:54:09 GMT

  Revision:          29953
  Repository:        https://redports.org/changeset/29953

---------------------------------------------------------------------

    Port:            science/sigrok-firmware-utils 20140418

      Buildgroup:     10.0-RELEASE/amd64
      Buildstatus:   SUCCESS
      Log: https://redports.org//~uffe/20140803002531-77129-229507/sigrok-firmware-utils-20140418.log

      Buildgroup:     10.0-RELEASE/i386
      Buildstatus:   SUCCESS
      Log: https://redports.org//~uffe/20140803002531-77129-229508/sigrok-firmware-utils-20140418.log

      Buildgroup:     9.2-RELEASE/amd64
      Buildstatus:   SUCCESS
      Log: https://redports.org//~uffe/20140803002531-77129-229509/sigrok-firmware-utils-20140418.log

      Buildgroup:     9.2-RELEASE/i386
      Buildstatus:   SUCCESS
      Log: https://redports.org//~uffe/20140803002531-77129-229510/sigrok-firmware-utils-20140418.log

      Buildgroup:     8.4-RELEASE/amd64
      Buildstatus:   SUCCESS
      Log: https://redports.org//~uffe/20140803002531-77129-229511/sigrok-firmware-utils-20140418.log

      Buildgroup:     8.4-RELEASE/i386
      Buildstatus:   SUCCESS
      Log: https://redports.org//~uffe/20140803002531-77129-229512/sigrok-firmware-utils-20140418.log

Buildarchive URL: <https://redports.org/buildarchive/20140803002531-77129>
redports <https://redports.org/>
Comment 7 John Marino freebsd_committer freebsd_triage 2014-08-03 06:23:31 UTC
good, but I didn't see the stage-qa section in this log so I guess it was a regular poudriere run.  In any case, moving to patch-ready...
Comment 8 Uffe Jakobsen 2014-08-03 16:25:28 UTC
(In reply to John Marino from comment #7)
> good, but I didn't see the stage-qa section in this log so I guess it was a
> regular poudriere run.  In any case, moving to patch-ready...

The poudriere log is the result of a "poudriere testport" run just like the others. I cannot really explain why it does not have a stage-qa section. This port differs from a normal port in the way that it does not download and build any source - all files are found inside the port itself in the files dir - I guess that this is the factor that comes in play here...
Comment 9 commit-hook freebsd_committer freebsd_triage 2014-08-03 22:09:50 UTC
A commit references this bug:

Author: marino
Date: Sun Aug  3 22:09:10 UTC 2014
New revision: 363948
URL: http://svnweb.freebsd.org/changeset/ports/363948

Log:
  Add new port: science/sigrok-firmware-utils

  PR:		188808
  Submitted by:	uffer

        ===============================================================

  The sigrok project aims at creating a portable, cross-platform,
  Free/Libre/Open-Source signal analysis software suite that supports
  various device types, such as logic analyzers, MSOs, oscilloscopes,
  multimeters, LCR meters, sound level meters, thermometers, hygrometers,
  anemometers, light meters, DAQs, dataloggers, function generators,
  spectrum analyzers, power supplies, GPIB interfaces, and more.

Changes:
  head/science/Makefile
  head/science/sigrok-firmware-utils/
  head/science/sigrok-firmware-utils/Makefile
  head/science/sigrok-firmware-utils/files/
  head/science/sigrok-firmware-utils/files/README.parsepe
  head/science/sigrok-firmware-utils/files/parseelf.py
  head/science/sigrok-firmware-utils/files/parsepe.py
  head/science/sigrok-firmware-utils/files/sigrok-fwextract-hantek-dso
  head/science/sigrok-firmware-utils/files/sigrok-fwextract-hantek-dso.1
  head/science/sigrok-firmware-utils/files/sigrok-fwextract-saleae-logic16
  head/science/sigrok-firmware-utils/files/sigrok-fwextract-saleae-logic16.1
  head/science/sigrok-firmware-utils/files/sigrok-fwextract-sysclk-lwla
  head/science/sigrok-firmware-utils/files/sigrok-fwextract-sysclk-lwla.1
  head/science/sigrok-firmware-utils/pkg-descr
Comment 10 John Marino freebsd_committer freebsd_triage 2014-08-03 22:11:49 UTC
One one moderate issue:
you were masking installation commands with "@".  It's okay to mask ${MKDIR} but not any command that installs files.  We want to see that on the logs.

I made some cosmetic changes (alignments) on the makefile and pkg-descr, nothing functional.

Thanks!