Bug 189127
| Summary: | devel/thrift-cpp fails with "Malformed conditional" errors when QT4 is defined | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Justin Hibbits <jrh29> |
| Component: | Individual Port(s) | Assignee: | Max Brazhnikov <makc> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | komarov, marino |
| Priority: | Normal | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
Responsible Changed From-To: freebsd-bugs->freebsd-ports-bugs ports PR. Maintainer of devel/thrift-cpp,
Please note that PR ports/189127 has just been submitted.
If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.
The full text of the PR can be found at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/189127
--
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool) CC maintainer again after the Bugzilla conversion. Max, since this is bsd.qt4.mk, I'm going to assign to you. I don't know if what the submitter did is legal. I'm tempted to reset the maintainer (komarov) of devel/thrift-cpp for twice not responding at all to this PR. A commit references this bug: Author: makc Date: Mon Aug 11 06:45:43 UTC 2014 New revision: 364589 URL: http://svnweb.freebsd.org/changeset/ports/364589 Log: devel/thrift-cpp: - Unbreak Makefile when building with QT4 support. USE_QT4 cannot be set after bsd.port.pre.mk and requires inclusion of bsd.port.options.mk (when used with options). However converting to options helpers saves us from additional include. - Replace spaces with tab while here PR: 189127 Reported by: jrh29@alumni.cwru.edu Approved by: maintainer timeout (3 months from the date of report, I didn't wait approval for my patch) MFH: 2014Q3 Changes: head/devel/thrift-cpp/Makefile Fixed, thanks for report! A commit references this bug: Author: makc Date: Tue Aug 19 09:33:05 UTC 2014 New revision: 365368 URL: http://svnweb.freebsd.org/changeset/ports/365368 Log: MFH: r364589 devel/thrift-cpp: - Unbreak Makefile when building with QT4 support. USE_QT4 cannot be set after bsd.port.pre.mk and requires inclusion of bsd.port.options.mk (when used with options). However converting to options helpers saves us from additional include. - Replace spaces with tab while here PR: 189127 Reported by: jrh29@alumni.cwru.edu Approved by: maintainer timeout (3 months from the date of report, I didn't wait approval for my patch) Approved by: portmgr (erwin) Changes: _U branches/2014Q3/ branches/2014Q3/devel/thrift-cpp/Makefile |
When OPTIONS_SET+=QT4 is set in /etc/make.conf, devel/thrift-cpp fails with the following error messages: make: "/usr/ports/Mk/bsd.qt.mk" line 472: Malformed conditional (${_QT_VERSION:M4*}) make: "/usr/ports/Mk/bsd.qt.mk" line 479: Malformed conditional (${_QT_VERSION:M4*}) make: "/usr/ports/Mk/bsd.qt.mk" line 479: Malformed conditional (${_QT_VERSION:M4*}) make: "/usr/ports/Mk/bsd.qt.mk" line 479: Malformed conditional (${_QT_VERSION:M4*}) make: "/usr/ports/Mk/bsd.qt.mk" line 479: Malformed conditional (${_QT_VERSION:M4*}) make: "/usr/ports/Mk/bsd.qt.mk" line 479: Malformed conditional (${_QT_VERSION:M4*}) make: "/usr/ports/Mk/bsd.qt.mk" line 479: Malformed conditional (${_QT_VERSION:M4*}) make: Fatal errors encountered -- cannot continue How-To-Repeat: Enable the QT4 option for devel/thrift-cpp (or globally). Run 'make all-depends-list' in devel/thrift-cpp