Bug 189156

Summary:

[build] [patch] include/Makefile does not honor MK_GSSAPI == no

Product:

Base System

Reporter:

Enji Cooper <ngie>

Component:

conf

Assignee:

Tijl Coosemans <tijl>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

tijl

Priority:

Normal

Version:

CURRENT

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
file.txt	none

Description Enji Cooper freebsd_committer

2014-05-01 01:00:00 UTC

I keep on running into ports/181004 because include/Makefile keeps on installing gssapi's headers. This is because include/Makefile does not honor MK_GSSAPI == no:

  9 SUBDIR= arpa gssapi protocols rpcsvc rpc xlocale
 10 INCS=   a.out.h ar.h assert.h bitstring.h complex.h cpio.h _ctype.h ctype.h \
 11         db.h \
 12         dirent.h dlfcn.h elf.h elf-hints.h err.h fmtmsg.h fnmatch.h fstab.h \
 13         fts.h ftw.h getopt.h glob.h grp.h gssapi.h \

Fix: Patch attached with submission follows:
How-To-Repeat: This should print out nothing:

% make -VSUBDIR -VINCS | grep gssapi

This should print out everything:

% make -VSUBDIR -VINCS -DWITH_GSSAPI | grep gssapi 

Example:

% make -VSUBDIR -VINCS | grep gssapi
% make -VSUBDIR -VINCS -DWITH_GSSAPI | grep gssapi
arpa protocols rpcsvc rpc xlocale gssapi
a.out.h ar.h assert.h bitstring.h complex.h cpio.h _ctype.h ctype.h  db.h  dirent.h dlfcn.h elf.h elf-hints.h err.h fmtmsg.h fnmatch.h fstab.h  fts.h ftw.h getopt.h glob.h grp.h  ieeefp.h ifaddrs.h  inttypes.h iso646.h kenv.h langinfo.h libgen.h limits.h link.h  locale.h malloc.h malloc_np.h memory.h monetary.h mpool.h mqueue.h  ndbm.h netconfig.h  netdb.h nl_types.h nlist.h nss.h nsswitch.h paths.h  printf.h proc_service.h pthread.h  pthread_np.h pwd.h ranlib.h readpassphrase.h regex.h  res_update.h resolv.h runetype.h search.h semaphore.h setjmp.h  signal.h spawn.h stab.h stdalign.h stdbool.h stddef.h  stdnoreturn.h stdio.h stdlib.h string.h stringlist.h  strings.h sysexits.h tar.h termios.h tgmath.h  time.h timeconv.h timers.h ttyent.h  uchar.h ulimit.h unistd.h utime.h utmpx.h uuid.h varargs.h  wchar.h wctype.h wordexp.h xlocale.h vis.h gssapi.h iconv.h osreldate.h

Comment 1 commit-hook freebsd_committer

2014-06-13 10:08:34 UTC

A commit references this bug:

Author: tijl
Date: Fri Jun 13 10:08:19 UTC 2014
New revision: 267441
URL: http://svnweb.freebsd.org/changeset/base/267441

Log:
  Don't install GSS-API headers when the GSSAPI option has been disabled.
  Some ports assume GSS-API is supported when they find the headers.

  PR:		189156
  Submitted by:	Garrett Cooper <yanegomi@gmail.com>

Changes:
  head/include/Makefile
  head/tools/build/mk/OptionalObsoleteFiles.inc

Comment 2 commit-hook freebsd_committer

2014-06-20 07:36:32 UTC

A commit references this bug:

Author: tijl
Date: Fri Jun 20 07:35:56 UTC 2014
New revision: 267666
URL: http://svnweb.freebsd.org/changeset/base/267666

Log:
  MFC r267441:

  Don't install GSS-API headers when the GSSAPI option has been disabled.
  Some ports assume GSS-API is supported when they find the headers.

  PR:		189156
  Submitted by:	Garrett Cooper <yanegomi@gmail.com>

Changes:
_U  stable/10/
  stable/10/include/Makefile
  stable/10/tools/build/mk/OptionalObsoleteFiles.inc

Comment 3 commit-hook freebsd_committer

2014-07-14 11:07:49 UTC

A commit references this bug:

Author: tijl
Date: Mon Jul 14 11:07:43 UTC 2014
New revision: 268618
URL: http://svnweb.freebsd.org/changeset/base/268618

Log:
  MFC r267441:

  Don't install GSS-API headers when the GSSAPI option has been disabled.
  Some ports assume GSS-API is supported when they find the headers.

  PR:		189156
  Submitted by:	Garrett Cooper <yanegomi@gmail.com>

Changes:
_U  stable/9/
_U  stable/9/include/
  stable/9/include/Makefile
_U  stable/9/tools/
_U  stable/9/tools/build/
  stable/9/tools/build/mk/OptionalObsoleteFiles.inc