Bug 189243

Summary: [exp-run] Mk/bsd.autotools.mk: fix running order
Product: Ports & Packages Reporter: Tijl Coosemans <tijl>
Component: Individual Port(s)Assignee: Antoine Brodin <antoine>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
bsd.autotools.mk.patch
none
bsd.autotools.mk.patch none

Description Tijl Coosemans freebsd_committer freebsd_triage 2014-05-02 15:50:01 UTC
The attached patch changes the order in which various autotools are
executed to match what autoreconf does.  The order used by autoreconf
is: libtoolize, aclocal, autoconf, autoheader, automake.

This should allow removing custom pre-configure and run-autotools
targets that some ports have.

The patch also sets default LIBTOOLIZE_ARGS:
-i: install missing files.
-c: copy files instead of linking them.  This is needed for USES=libtool
    to be able to patch them.
-f: force replacement of existing files.  This ensures all files belong
    to the same version.
These should work for most if not all ports.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-02 15:50:05 UTC
Responsible Changed
From-To: freebsd-ports-bugs->autotools

bsd.autotools.mk is autotools territory (via the GNATS Auto Assign Tool)
Comment 2 Tijl Coosemans freebsd_committer freebsd_triage 2014-05-02 15:57:23 UTC
Responsible Changed
From-To: autotools->portmgr

To portmgr for exp-run.
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2014-05-04 22:59:00 UTC
Responsible Changed
From-To: portmgr->antoine

Take, i will run it next week on package19
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2014-05-06 08:19:29 UTC
Hi,

The exp-run results are available at:
http://package19.nyi.freebsd.org/bulk/91amd64-default-pr_189243/2014-05-05_05h30m27s/

There were 3 new failures but only 1 is related to the autotools change:
+ {"origin"=>"databases/vsqlite", "pkgname"=>"vsqlite-0.3.12_2",
"phase"=>"stage", "errortype"=>"cluster"}
+ {"origin"=>"lang/ezm3", "pkgname"=>"ezm3-1.1_2",
"phase"=>"install/timeout", "errortype"=>"cluster"}
+ {"origin"=>"www/google-appengine",
"pkgname"=>"google-appengine-1.9.2", "phase"=>"fetch",
"errortype"=>"fetch"}

The failure related to the autotools change is databases/vsqlite
error log: http://package19.nyi.freebsd.org/bulk/91amd64-default-pr_189243/2014-05-05_05h30m27s/logs/errors/vsqlite-0.3.12_2.log
success log from baseline:
http://package20.nyi.freebsd.org/bulk/91amd64-default-baseline/352972/logs/vsqlite-0.3.12_2.log

Cheers,

Antoine
Comment 5 Tijl Coosemans freebsd_committer freebsd_triage 2014-05-06 09:46:16 UTC
On Tue, 6 May 2014 09:19:29 +0200 Antoine Brodin wrote:
> Hi,
> 
> The exp-run results are available at:
> http://package19.nyi.freebsd.org/bulk/91amd64-default-pr_189243/2014-05-05_05h30m27s/
> 
> There were 3 new failures but only 1 is related to the autotools change:
> + {"origin"=>"databases/vsqlite", "pkgname"=>"vsqlite-0.3.12_2",
> "phase"=>"stage", "errortype"=>"cluster"}
> + {"origin"=>"lang/ezm3", "pkgname"=>"ezm3-1.1_2",
> "phase"=>"install/timeout", "errortype"=>"cluster"}
> + {"origin"=>"www/google-appengine",
> "pkgname"=>"google-appengine-1.9.2", "phase"=>"fetch",
> "errortype"=>"fetch"}
> 
> The failure related to the autotools change is databases/vsqlite
> error log: http://package19.nyi.freebsd.org/bulk/91amd64-default-pr_189243/2014-05-05_05h30m27s/logs/errors/vsqlite-0.3.12_2.log
> success log from baseline:
> http://package20.nyi.freebsd.org/bulk/91amd64-default-baseline/352972/logs/vsqlite-0.3.12_2.log

Thanks.  I've attached a new patch.  The fix for vsqlite is to replace
the post-install target with INSTALL_TARGET=install-strip.  The
pre-configure target has been replaced with USE_AUTOTOOLS.
Redports results: https://redports.org/buildarchive/20140506083700-18847/
Comment 6 Antoine Brodin freebsd_committer freebsd_triage 2014-05-06 09:55:25 UTC
ok approved,  thanks!
Comment 7 Tijl Coosemans freebsd_committer freebsd_triage 2014-05-06 11:46:11 UTC
State Changed
From-To: open->closed

Committed in r353081.