Bug 189376

Summary: [maintainer-update] Fixes for security/py-fail2ban 0.9.0 installation
Product: Ports & Packages Reporter: theis
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description theis 2014-05-05 18:00:00 UTC 
The latest version of fail2ban requires a directory /var/db/fail2ban, but the setup did not create that directory.

I hope I create the directory the correct way this time.

I don't hink we have to increment the port revision: There is nothing new in fail2ban itself. And those who already installed it have the directory created or fail2ban would not start.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-06 02:36:51 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

sunpoet@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-05-13 19:22:32 UTC 
Author: adamw
Date: Tue May 13 18:22:28 2014
New Revision: 353975
URL: http://svnweb.freebsd.org/changeset/ports/353975
QAT: https://qat.redports.org/buildarchive/r353975/

Log:
  Install manpages [1] and create /var/{run,db} directories [2]
  
  PR:		ports/189781 [1], ports/189376 [2]
  Approved by:	maintainer

Modified:
  head/security/py-fail2ban/Makefile
  head/security/py-fail2ban/pkg-plist

Modified: head/security/py-fail2ban/Makefile
==============================================================================
--- head/security/py-fail2ban/Makefile	Tue May 13 17:11:36 2014	(r353974)
+++ head/security/py-fail2ban/Makefile	Tue May 13 18:22:28 2014	(r353975)
@@ -2,6 +2,7 @@
 
 PORTNAME=	fail2ban
 PORTVERSION=	0.9.0
+PORTREVISION=	1
 CATEGORIES=	security python
 PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
 
@@ -49,5 +50,11 @@ post-install:
 	@${MKDIR} ${STAGEDIR}${FAIL2BAN_DBDIR}
 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
 	(cd ${WRKSRC}/ && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR})
+.for file in fail2ban-client fail2ban-regex fail2ban-server fail2ban
+	@${INSTALL_MAN} ${WRKSRC}/man/${file}.1 ${STAGEDIR}${MANPREFIX}/man/man1
+.endfor
+	@${INSTALL_MAN} ${WRKSRC}/man/jail.conf.5 ${STAGEDIR}${MANPREFIX}/man/man5/fail2ban-jail.conf.5
+	@${TOUCH} ${STAGEDIR}${FAIL2BAN_DBDIR}/.keep_me
+	@${TOUCH} ${STAGEDIR}/var/run/fail2ban/.keep_me
 
 .include <bsd.port.mk>

Modified: head/security/py-fail2ban/pkg-plist
==============================================================================
--- head/security/py-fail2ban/pkg-plist	Tue May 13 17:11:36 2014	(r353974)
+++ head/security/py-fail2ban/pkg-plist	Tue May 13 18:22:28 2014	(r353975)
@@ -199,6 +199,13 @@ bin/fail2ban-server
 %%PYTHON_SITELIBDIR%%/fail2ban/tests/__init__.pyc
 %%PYTHON_SITELIBDIR%%/fail2ban/tests/utils.py
 %%PYTHON_SITELIBDIR%%/fail2ban/tests/utils.pyc
+man/man1/fail2ban-client.1.gz
+man/man1/fail2ban-regex.1.gz
+man/man1/fail2ban-server.1.gz
+man/man1/fail2ban.1.gz
+man/man5/fail2ban-jail.conf.5.gz
+/var/db/fail2ban/.keep_me
+/var/run/fail2ban/.keep_me
 @dirrm %%PYTHON_SITELIBDIR%%/fail2ban/tests
 @dirrm %%PYTHON_SITELIBDIR%%/fail2ban/server
 @dirrm %%PYTHON_SITELIBDIR%%/fail2ban/client
@@ -208,3 +215,5 @@ bin/fail2ban-server
 @dirrmtry %%ETCDIR%%/fail2ban.d
 @dirrmtry %%ETCDIR%%/action.d
 @dirrmtry %%ETCDIR%%
+@dirrmtry /var/run/fail2ban
+@dirrmtry /var/db/fail2ban
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Adam Weinberger freebsd_committer freebsd_triage 2014-05-13 19:23:35 UTC 
State Changed
From-To: open->closed

Committed this along with ports/189781, as it would have required 
another PORTREVISION bump. 

pkg-create(8) won't install empty directories, so your version 
wouldn't have worked. I just put some empty files in there so 
pkg-create(8) would DTRT. There's no need for the @cmd commands 
anymore. 

Note that you still have some orphaned stuff in STAGEDIR. A few 
"rm" commands in post-install: would clean that up. See the output 
of "make check-plist" for details.