Bug 189487

Summary: [PATCH] astro/cfitsio: Actually make -lz be passed to the linker.
Product: Ports & Packages Reporter: Raphael Kubo da Costa <rakuco>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me CC: sunpoet
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
cfitsio-3.360.patch none

Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-05-08 23:20:01 UTC 
The way the port's build system is set up, changing LDFLAGS does not have any effect. Instead, one should specify additional libraries at configure-time by setting LIBS, which is then passed to the linker at build time and is also used in the port's .pc file.

This should unbreak astro/wcslib when this port is installed, as it the detection is currently failing because of missing zlib symbols in the test programs built at configure-time.

Port maintainer (sunpoet@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 1.02 (mode: change, diff: SVN)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-08 23:20:09 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-05-09 16:26:10 UTC 
Author: sunpoet
Date: Fri May  9 15:26:05 2014
New Revision: 353466
URL: http://svnweb.freebsd.org/changeset/ports/353466
QAT: https://qat.redports.org/buildarchive/r353466/

Log:
  - Pass -lz to libdata/pkgconfig/cfitsio.pc
  - Bump PORTREVISION for package change
  
  PR:		ports/189487
  Submitted by:	rakuco

Modified:
  head/astro/cfitsio/Makefile

Modified: head/astro/cfitsio/Makefile
==============================================================================
--- head/astro/cfitsio/Makefile	Fri May  9 15:23:12 2014	(r353465)
+++ head/astro/cfitsio/Makefile	Fri May  9 15:26:05 2014	(r353466)
@@ -3,7 +3,7 @@
 
 PORTNAME=	cfitsio
 PORTVERSION=	3.360
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	astro
 MASTER_SITES=	http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/ \
 		http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/oldvers/ \
@@ -24,9 +24,9 @@ OPTIONS_DEFINE=	DOCS
 ALL_TARGET=	libcfitsio.a shared
 CFLAGS+=	-I${INCLUDEDIR}
 CONFIGURE_ARGS=	ac_cv_prog_FC=f2c
+CONFIGURE_ENV=	LIBS="-L${LIBDIR} -lz"
 GNU_CONFIGURE=	yes
 MAKE_ARGS=	ZLIB_SOURCES="zlib/zcompress.c zlib/zuncompress.c"
-LDFLAGS+=	-L${LIBDIR} -lz
 USE_LDCONFIG=	yes
 USES=		pkgconfig
 WRKSRC=		${WRKDIR}/${PORTNAME}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2014-05-09 16:26:19 UTC 
State Changed
From-To: open->closed

Committed. Thanks!