Summary: | lang/ocaml: ocamlbuild doesn't handle SIGPIPE | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Török Edwin <edwin> | ||||
Component: | Individual Port(s) | Assignee: | John Marino <marino> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | marino, michipili | ||||
Priority: | Normal | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Török Edwin
2014-05-12 14:50:01 UTC
Note: ocamlbuild is part of lang/ocaml in ports. Maintainer of lang/ocaml, Please note that PR ports/189710 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/189710 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool) Reassigning to maintainer. This got lost in the transition to bugzilla. Michael, any idea? There is a seemingly-related bug-report[1] upstream. It seems that there is a patch for this. I will investigate the issue to reproduce it and see if the patch helps. http://caml.inria.fr/mantis/view.php?id=5371 unrelated, but in 2 weeks the following ports are going to be removed: devel/ocaml-camomile devel/ocaml-equeue devel/ocaml-event devel/ocaml-sdl devel/ocamlweb databases/ocaml-pgocaml lang/metaocaml lang/ocaml-camlidl lang/ocaml-mode You may want to stage and adopt some? I don't know. Just letting you know. John, thank you for pointing this out, I will take a look at this as well! Created attachment 146031 [details]
Patch for lang/ocaml
I applied upstream patch for the issue number 0005371 (upstream issue) and
could build and reinstall and OCaml, and was able to build and install
textproc/ocaml-text with the corrected ocamlbuild.
The patch has git a/b headers, so it might require stripping before applying it in /usr/ports.
Suggested commit message:
lang/ocaml: Improve jobcontrol in ocamlbuild
Apply patch for upstream issue 0005371. It improves jobcontrol in
ocamlbuild and fixes some faulty sigpipe affecting ports built
with ocamlbuild.
PR: 189710
Submitted by: maintainer (Michael Gruenewald)
Patch by: glondu
the a/ b/ thing is unfortunate. I have to manually remove those for it to work with svn patch. For regular patch it's no problem, -p 1 fixes it. A commit references this bug: Author: marino Date: Tue Aug 19 13:55:12 UTC 2014 New revision: 365380 URL: http://svnweb.freebsd.org/changeset/ports/365380 Log: lang/ocaml: Improve jobcontrol in ocamlbuild Apply patch for upstream issue 0005371. It improves job control in ocamlbuild and fixes some faulty sigpipe affecting ports build with ocamlbuild. PR: 189710 Submitted by: edwin (skylable.com) patch by: glondu Approved by: maintainer (Michael Gruenewald) Changes: head/lang/ocaml/Makefile head/lang/ocaml/files/patch-ocamlbuild Thanks, Michael. Great! For the a/ b/ thing I am currently using git for my work on ports because I know it quite well and gave up subversion for about 4 or 5 years. So, I am asking, if you would recommend to use subversion for working on ports? Would it be kind of easier to generate patches and stay up-to-date? (In reply to Michael Grünewald from comment #13) > Great! > > For the a/ b/ thing I am currently using git for my work on ports because > I know it quite well and gave up subversion for about 4 or 5 years. So, I am > asking, if you would recommend to use subversion for working on ports? Would > it be kind of easier to generate patches and stay up-to-date? I think it would be a little easier but not mandatory. Obviously I was able to cope. If you submit diffs without that a/ b/ diff Index stuff (and there must be an option for that) then it wouldn't make a difference at all. |