Bug 190592
| Summary: | [exp-run] Support LIBS variable (like LDFLAGS) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Tijl Coosemans <tijl> | ||||||
| Component: | Ports Framework | Assignee: | Tijl Coosemans <tijl> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | portmgr | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
--- Mk/bsd.port.mk (revision 356378)
+++ Mk/bsd.port.mk (working copy)
@@ -3632,7 +3632,7 @@ do-configure:
${SET_LATE_CONFIGURE_ARGS} \
if ! ${SETENV} CC="${CC}" CPP="${CPP}" CXX="${CXX}" \
CFLAGS="${CFLAGS}" CPPFLAGS="${CPPFLAGS}" CXXFLAGS="${CXXFLAGS}" \
- LDFLAGS="${LDFLAGS}" \
+ LDFLAGS="${LDFLAGS}" LIBS=${LIBS} \
INSTALL="/usr/bin/install -c ${_BINOWNGRP}" \
INSTALL_DATA="${INSTALL_DATA}" \
INSTALL_LIB="${INSTALL_LIB}" \
Maybe some quotes are needed?
(In reply to Antoine Brodin from comment #1) > --- Mk/bsd.port.mk (revision 356378) > +++ Mk/bsd.port.mk (working copy) > @@ -3632,7 +3632,7 @@ do-configure: > ${SET_LATE_CONFIGURE_ARGS} \ > if ! ${SETENV} CC="${CC}" CPP="${CPP}" CXX="${CXX}" \ > CFLAGS="${CFLAGS}" CPPFLAGS="${CPPFLAGS}" CXXFLAGS="${CXXFLAGS}" \ > - LDFLAGS="${LDFLAGS}" \ > + LDFLAGS="${LDFLAGS}" LIBS=${LIBS} \ > INSTALL="/usr/bin/install -c ${_BINOWNGRP}" \ > INSTALL_DATA="${INSTALL_DATA}" \ > INSTALL_LIB="${INSTALL_LIB}" \ > > Maybe some quotes are needed? Yes, that should be LIBS="${LIBS}" Take for exp-run Hi, Exp-run results are available at: http://package22.nyi.freebsd.org/build.html?mastername=91amd64-default-pr190592&build=2014-06-05_04h43m18s There were around 1500 ports skipped so a new iteration will be needed if you still think this patch is desirable. 33 new ports failure: + {"origin"=>"astro/roadmap", "pkgname"=>"roadmap-1.2.1_3", "phase"=>"build", "errortype"=>"makefile"} + {"origin"=>"audio/festival", "pkgname"=>"festival-2.1_1", "phase"=>"build", "errortype"=>"linker_error"} + {"origin"=>"audio/playgsf", "pkgname"=>"playgsf-0.7.1_2", "phase"=>"build", "errortype"=>"linker_error"} + {"origin"=>"benchmarks/dbench", "pkgname"=>"dbench-4.0_2", "phase"=>"build", "errortype"=>"missing_header"} + {"origin"=>"benchmarks/netio", "pkgname"=>"netio-1.26", "phase"=>"build", "errortype"=>"linker_error"} + {"origin"=>"comms/predict", "pkgname"=>"predict-2.2.3", "phase"=>"build", "errortype"=>"linker_error"} + {"origin"=>"devel/pypersrc", "pkgname"=>"pypersrc-20120106_1", "phase"=>"build", "errortype"=>"configure_error"} + {"origin"=>"games/torcs", "pkgname"=>"torcs-1.3.6", "phase"=>"build", "errortype"=>"makefile"} + {"origin"=>"graphics/gimageview", "pkgname"=>"gimageview-0.2.27_13", "phase"=>"build", "errortype"=>"missing_header"} + {"origin"=>"lang/hugs", "pkgname"=>"hugs98-200609_5", "phase"=>"build", "errortype"=>"configure_error"} + {"origin"=>"lang/ruby21", "pkgname"=>"ruby21-2.1.1_2,1", "phase"=>"package", "errortype"=>"PLIST"} + {"origin"=>"mail/crm114", "pkgname"=>"crm114-20100106_1", "phase"=>"build", "errortype"=>"missing_header"} + {"origin"=>"mail/lmtp2nntp", "pkgname"=>"lmtp2nntp-1.4.1", "phase"=>"configure", "errortype"=>"configure_error"} + {"origin"=>"misc/pdmenu", "pkgname"=>"pdmenu-1.3.2_1", "phase"=>"build", "errortype"=>"missing_header"} + {"origin"=>"multimedia/libmpeg3", "pkgname"=>"libmpeg3-1.8", "phase"=>"build", "errortype"=>"linker_error"} + {"origin"=>"multimedia/opencinematools", "pkgname"=>"opencinematools-1.1.2_1", "phase"=>"build", "errortype"=>"linker_error"} + {"origin"=>"net-mgmt/nagios", "pkgname"=>"nagios-3.5.1_5", "phase"=>"build", "errortype"=>"missing_header"} + {"origin"=>"net-mgmt/nagios4", "pkgname"=>"nagios4-4.0.6", "phase"=>"build", "errortype"=>"missing_header"} + {"origin"=>"net-mgmt/rate", "pkgname"=>"rate-0.9", "phase"=>"build", "errortype"=>"linker_error"} + {"origin"=>"net/freeradius2", "pkgname"=>"freeradius-2.2.5", "phase"=>"build", "errortype"=>"missing_header"} + {"origin"=>"net/freeradius3", "pkgname"=>"freeradius3-3.0.3_2", "phase"=>"build", "errortype"=>"missing_header"} + {"origin"=>"net/freeswitch-core-devel", "pkgname"=>"freeswitch-core-devel-1.2.3_2", "phase"=>"build", "errortype"=>"configure_error"} + {"origin"=>"net/ldap2dns", "pkgname"=>"ldap2dns-0.4.2_1", "phase"=>"build", "errortype"=>"linker_error"} + {"origin"=>"net/nast", "pkgname"=>"nast-0.2.0_4", "phase"=>"patch", "errortype"=>"???"} + {"origin"=>"net/ntopng", "pkgname"=>"ntopng-1.1_1", "phase"=>"build", "errortype"=>"configure_error"} + {"origin"=>"net/siproxd", "pkgname"=>"siproxd-0.7.2_2", "phase"=>"configure", "errortype"=>"configure_error"} + {"origin"=>"print/cups-base", "pkgname"=>"cups-base-1.7.2_1", "phase"=>"build", "errortype"=>"linker_error"} + {"origin"=>"security/p11-kit", "pkgname"=>"p11-kit-0.20.2_1", "phase"=>"build", "errortype"=>"nested_declaration"} + {"origin"=>"security/sectok", "pkgname"=>"sectok-20030825", "phase"=>"build", "errortype"=>"???"} + {"origin"=>"security/vlog", "pkgname"=>"vlog-1.1f_1", "phase"=>"build", "errortype"=>"termios"} + {"origin"=>"sysutils/dar", "pkgname"=>"dar-2.4.12_1", "phase"=>"build", "errortype"=>"linker_error"} + {"origin"=>"x11-wm/fbcmd", "pkgname"=>"fbcmd-0.5.1_4", "phase"=>"build", "errortype"=>"linker_error"} + {"origin"=>"x11/rxvt-unicode", "pkgname"=>"rxvt-unicode-9.20", "phase"=>"build", "errortype"=>"linker_error"} Failure logs: http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/roadmap-1.2.1_3.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/festival-2.1_1.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/playgsf-0.7.1_2.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/dbench-4.0_2.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/netio-1.26.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/predict-2.2.3.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/pypersrc-20120106_1.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/torcs-1.3.6.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/gimageview-0.2.27_13.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/hugs98-200609_5.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/ruby21-2.1.1_2,1.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/crm114-20100106_1.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/lmtp2nntp-1.4.1.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/pdmenu-1.3.2_1.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/libmpeg3-1.8.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/opencinematools-1.1.2_1.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/nagios-3.5.1_5.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/nagios4-4.0.6.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/rate-0.9.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/freeradius-2.2.5.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/freeradius3-3.0.3_2.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/freeswitch-core-devel-1.2.3_2.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/ldap2dns-0.4.2_1.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/nast-0.2.0_4.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/ntopng-1.1_1.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/siproxd-0.7.2_2.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/cups-base-1.7.2_1.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/p11-kit-0.20.2_1.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/sectok-20030825.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/vlog-1.1f_1.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/dar-2.4.12_1.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/fbcmd-0.5.1_4.log http://package22.nyi.freebsd.org/data/91amd64-default-pr190592/2014-06-05_04h43m18s/logs/errors/rxvt-unicode-9.20.log Created attachment 143582 [details]
patch2
This patch should fix all build failures.
take for exp-run Hi, Results of the exp-run are available at http://package22.nyi.freebsd.org/build.html?mastername=91amd64-default-pr190592&build=2014-06-10_05h04m17s No new failures with it, looks good! (In reply to Antoine Brodin from comment #7) > Hi, > > Results of the exp-run are available at > http://package22.nyi.freebsd.org/build.html?mastername=91amd64-default- > pr190592&build=2014-06-10_05h04m17s > No new failures with it, looks good! Does this mean it's approved? I removed the sanity checks by the way. Making them conditional on GNU_CONFIGURE isn't enough. Only makefiles generated with automake can be expected to support both CPPFLAGS and LIBS and even then upstream can break that support. So automated sanity checking doesn't work. yes approved A commit references this bug: Author: tijl Date: Wed Jun 11 14:50:15 UTC 2014 New revision: 357486 URL: http://svnweb.freebsd.org/changeset/ports/357486 Log: Support LIBS like LDFLAGS. - Add LIBS="${LIBS}" to MAKE_ENV and CONFIGURE_ENV. - Add an option helper for LIBS. - Adjust all ports that already use LIBS. Also remove references to PTHREAD_CFLAGS and PTHREAD_LIBS while here. - Some ports did not support having a LIBS environment variable and required additional patches. Somewhat simplified a linker command line looks like: ${CC} ${src_LDFLAGS} ${LDFLAGS} ${src_LIBS} ${LIBS} where src_LDFLAGS and src_LIBS are controlled by upstream and LDFLAGS and LIBS can be controlled by us. If possible -L and -l flags need to be added to LIBS to make sure they appear after any -L and -l flags set by upstream. Many ports currently add -L${LOCALBASE}/lib to LDFLAGS but this may appear too early on the command line causing installed libraries to be linked in instead of freshly built ones. Additional changes: benchmarks/netio: Replace WITH_IPV6 with an IPV6 option. comms/gnokii: Replace some patches with USES=pathfix. Also remove -fPIC. graphics/gimageview: USES=libtool and install desktop file in DESKTOPDIR. graphics/visionworkbench: Remove FreeBSD 7 support. multimedia/libmovtar: New LIB_DEPENDS syntax. multimedia/opencinematools: Use standard do-build. net/siproxd: USES=libtool:keepla (port actually needs .la files for plugins) net-mgmt/nagios: Remove -fPIC. net-mgmt/nagios4: Remove -fPIC. print/cups-base: Only add -lssp_nonshared on i386 and OSVERSION < 1000036. security/p11-kit: Replace PTHREAD_LIBS in CONFIGURE_ENV with ac_cv_func_pthread_mutexattr_init=no in CONFIGURE_ARGS. This skips a test in configure that falsely detects pthread_mutexattr_init in our libc. sysutils/dar: Fix iconv detection. x11/rxvt-unicode: Remove -lstdc++ and patch configure to remove a FreeBSD hack and use $CXX as linker as on other platforms. PR: 190592 Exp-run by: antoine Approved by: portmgr (antoine) Changes: head/Mk/bsd.gecko.mk head/Mk/bsd.options.mk head/Mk/bsd.port.mk head/archivers/rpm/Makefile head/astro/cfitsio/Makefile head/astro/openuniverse/Makefile head/astro/roadmap/Makefile head/astro/xplanet/Makefile head/audio/deadbeef/Makefile head/audio/fdk-aac/Makefile head/audio/festival/Makefile head/audio/firefly/Makefile head/audio/jack/Makefile head/audio/mp3plot/Makefile head/audio/playgsf/Makefile head/audio/pulseaudio/Makefile head/audio/rhythmbox/Makefile head/audio/rplay/Makefile head/audio/spiralsynthmodular/Makefile head/benchmarks/dbench/Makefile head/benchmarks/netio/Makefile head/chinese/oto/Makefile head/chinese/reciteword/Makefile head/comms/gmfsk/Makefile head/comms/gnokii/Makefile head/comms/gnokii/files/patch-common-Makefile.in head/comms/gnokii/files/patch-xgnokii-Makefile.in head/comms/hamlib/Makefile head/comms/minicom/Makefile head/comms/nokryptia/Makefile head/comms/predict/Makefile head/comms/predict/files/Makefile head/converters/fix-mime-charset/Makefile head/converters/pdf2djvu/Makefile head/converters/rcctools/Makefile head/databases/dbtool/Makefile head/databases/hk_classes/Makefile head/databases/libodbc++/Makefile head/databases/oracle_odbc_driver/Makefile head/databases/pgadmin3/Makefile head/deskutils/gnome-main-menu/Makefile head/deskutils/logjam/Makefile head/deskutils/multisync/Makefile head/devel/apr1/Makefile head/devel/apr2/Makefile head/devel/asmutils/Makefile head/devel/ccrtp/Makefile head/devel/google-perftools/Makefile head/devel/ifd-test/Makefile head/devel/libgutenfetch/Makefile head/devel/libunicode/Makefile head/devel/libzvbi/Makefile head/devel/nspr/Makefile head/devel/pypersrc/Makefile head/devel/srecord/Makefile head/dns/libidn/Makefile head/editors/joe/Makefile head/editors/joe2/Makefile head/editors/mlview/Makefile head/editors/xcoral/Makefile head/emulators/fuse/Makefile head/emulators/vba/Makefile head/emulators/x48/Makefile head/ftp/lftp/Makefile head/ftp/proftpd/Makefile head/ftp/wput/Makefile head/games/alienarena/Makefile head/games/battalion/Makefile head/games/chroma/Makefile head/games/frobtads/Makefile head/games/glest/Makefile head/games/gnomeattacks/Makefile head/games/gnuchess/Makefile head/games/gracer/Makefile head/games/gturing/Makefile head/games/highmoon/Makefile head/games/lbreakout/Makefile head/games/pioneers/Makefile head/games/sdb/Makefile head/games/spacejunk/Makefile head/games/super_methane_brothers/Makefile head/games/torcs/Makefile head/games/trophy/Makefile head/games/tsito/Makefile head/games/tuxkart/Makefile head/games/warzone2100/Makefile head/games/xqf/Makefile head/graphics/EZWGL/Makefile head/graphics/bugle/Makefile head/graphics/colord/Makefile head/graphics/danpei/Makefile head/graphics/enblend/Makefile head/graphics/epeg/Makefile head/graphics/flam3/Makefile head/graphics/gcolor/Makefile head/graphics/gimageview/Makefile head/graphics/gimageview/files/patch-ltmain.sh head/graphics/gimageview/pkg-plist head/graphics/gimp-app/Makefile head/graphics/gimp-resynthesizer/Makefile head/graphics/gle/Makefile head/graphics/gltt/Makefile head/graphics/gphoto2/Makefile head/graphics/gtkgraph/Makefile head/graphics/jpeginfo/Makefile head/graphics/kudu/Makefile head/graphics/libvisual/Makefile head/graphics/libvisual04-plugins/Makefile head/graphics/php-facedetect/Makefile head/graphics/phplot/Makefile head/graphics/pngnq/Makefile head/graphics/povray37/Makefile head/graphics/radius-engine/Makefile head/graphics/stamp/Makefile head/graphics/tesseract/Makefile head/graphics/visionworkbench/Makefile head/graphics/xaos/Makefile head/graphics/xsane/Makefile head/graphics/zphoto/Makefile head/irc/bitchx/Makefile head/irc/miau/Makefile head/irc/xchat/Makefile head/japanese/groff/Makefile head/japanese/jvim3/Makefile head/japanese/php5-mecab/Makefile head/java/jikes/Makefile head/korean/eterm/Makefile head/korean/eterm/files/patch-ac head/lang/hugs/Makefile head/lang/lush/Makefile head/lang/php5/Makefile head/lang/php53/Makefile head/lang/php55/Makefile head/lang/python27/Makefile head/lang/ruby19/Makefile head/lang/ruby20/Makefile head/lang/ruby21/Makefile head/mail/bogofilter/Makefile head/mail/crm114/Makefile head/mail/cyrus-imapd23/Makefile head/mail/cyrus-imapd24/Makefile head/mail/dspam/Makefile head/mail/dspam-devel/Makefile head/mail/gbuffy/Makefile head/mail/gmime2/Makefile head/mail/gmime24/Makefile head/mail/lmtp2nntp/files/patch-configure head/mail/mboxgrep/Makefile head/mail/milter-greylist/Makefile head/mail/milter-greylist-devel/Makefile head/mail/mmr/Makefile head/mail/popper/Makefile head/mail/popular/Makefile head/mail/qmailadmin/Makefile head/mail/qpopper/Makefile head/mail/smtpmail/Makefile head/mail/sylpheed/Makefile head/math/geg/Makefile head/math/goblin/Makefile head/math/numdiff/Makefile head/math/oleo/Makefile head/math/tablix/Makefile head/misc/gnome-mime-data/Makefile head/misc/gnuls/Makefile head/misc/lingoteach/Makefile head/misc/pdmenu/Makefile head/misc/xosd/Makefile head/multimedia/gmencoder/Makefile head/multimedia/gnome-mplayer/Makefile head/multimedia/libmovtar/Makefile head/multimedia/libmpeg3/Makefile head/multimedia/libmtp/Makefile head/multimedia/libtheora/Makefile head/multimedia/mpeg4ip/Makefile head/multimedia/opencinematools/Makefile head/multimedia/totem/Makefile head/multimedia/xawtv/Makefile head/net/arping/Makefile head/net/c3270/Makefile head/net/dante/Makefile head/net/freeradius2/Makefile head/net/freeradius3/Makefile head/net/freeswitch-core-devel/Makefile head/net/freeswitch-core-devel/files/patch-build-modmake.rules.in head/net/gutenfetch/Makefile head/net/isc-dhcp41-server/Makefile head/net/isc-dhcp42-server/Makefile head/net/isc-dhcp43-server/Makefile head/net/ldap2dns/Makefile head/net/nast/Makefile head/net/nast/files/patch-configure head/net/netdude/Makefile head/net/ntopng/Makefile head/net/ntopng/files/patch-configure head/net/openldap24-server/Makefile head/net/rtpproxy/Makefile head/net/siproxd/Makefile head/net/siproxd/files/patch-aclocal.m4 head/net/siproxd/files/patch-configure head/net/siproxd/files/patch-libltdl_aclocal.m4 head/net/siproxd/files/patch-libltdl_configure head/net/siproxd/pkg-plist head/net/tac_plus4/Makefile head/net/traff/Makefile head/net/trafshow3/Makefile head/net/trickle/Makefile head/net/tsclient/Makefile head/net/uplog/Makefile head/net/wire/Makefile head/net/wireshark/Makefile head/net-im/libpurple/Makefile head/net-im/mu-conference/Makefile head/net-mgmt/ap-utils/Makefile head/net-mgmt/bwm-ng/Makefile head/net-mgmt/collectd/Makefile head/net-mgmt/collectd5/Makefile head/net-mgmt/disco/Makefile head/net-mgmt/flow-extract/Makefile head/net-mgmt/icinga/Makefile head/net-mgmt/nagios/Makefile head/net-mgmt/nagios4/Makefile head/net-mgmt/nbtscan/Makefile head/net-mgmt/nefu/Makefile head/net-mgmt/rate/Makefile head/net-mgmt/sing/Makefile head/net-mgmt/snmp4nagios/Makefile head/net-p2p/jigdo/Makefile head/net-p2p/teknap/Makefile head/news/newsstar/Makefile head/news/noffle/Makefile head/print/a2ps/Makefile head/print/cups-base/Makefile head/print/gv/Makefile head/print/openprinting/Makefile head/print/ttf2pt1/Makefile head/security/bsmtrace/Makefile head/security/libgnomesu/Makefile head/security/libgringotts/Makefile head/security/libpwquality/Makefile head/security/openscep/Makefile head/security/p11-kit/Makefile head/security/prelude-manager/Makefile head/security/sectok/Makefile head/security/steghide/Makefile head/security/vlog/Makefile head/security/xca/Makefile head/sysutils/apcupsd/Makefile head/sysutils/coreutils/Makefile head/sysutils/dar/Makefile head/sysutils/dar/files/patch-configure head/sysutils/dar/files/patch-src-dar-Makefile.in head/sysutils/dc3dd/Makefile head/sysutils/fileschanged/Makefile head/sysutils/gcombust/Makefile head/sysutils/graveman/Makefile head/sysutils/htop/Makefile head/sysutils/mate-system-monitor/Makefile head/sysutils/uniutils/Makefile head/textproc/exempi/Makefile head/textproc/redland/Makefile head/textproc/scrollkeeper/Makefile head/textproc/spellutils/Makefile head/textproc/stardict3/Makefile head/textproc/uim-el/Makefile head/www/dpsearch/Makefile head/www/epiphany/Makefile head/www/mod_encoding/Makefile head/www/mod_log_sql2/Makefile head/www/mod_log_sql2-dtc/Makefile head/www/shttpd/Makefile head/www/sitecopy/Makefile head/www/webalizer/Makefile head/www/wwwoffle/Makefile head/x11/gdm/Makefile head/x11/gnome-swallow/Makefile head/x11/libxcb/Makefile head/x11/mrxvt/Makefile head/x11/rxvt-devel/Makefile head/x11/rxvt-unicode/Makefile head/x11/rxvt-unicode/files/patch-configure head/x11/wbar/Makefile head/x11/workrave/Makefile head/x11/x3270/Makefile head/x11/xscreensaver-gnome/Makefile head/x11/xterm/Makefile head/x11/xtermcontrol/Makefile head/x11/zenity/Makefile head/x11-fm/nautilus/Makefile head/x11-toolkits/gtk12/Makefile head/x11-toolkits/gtksourceview/Makefile head/x11-toolkits/gtksourceview2/Makefile head/x11-toolkits/libzvt/Makefile head/x11-toolkits/py-gnome2/Makefile head/x11-toolkits/wxgtk28/Makefile head/x11-toolkits/wxgtk30/Makefile head/x11-wm/fbcmd/Makefile head/x11-wm/fluxbox/Makefile |
Created attachment 143345 [details] patch When a port builds two libraries with libtool with one linking to the other, libtool will relink that library on installation. I currently don't fully understand why it does this, but the way it does this in combination with staging means we need to be careful with things like LDFLAGS+=-L${LOCALBASE}/lib. During build phase when linking a library libA with libB using for instance ../libBsrc/libB.la, libtool will replace that path with ../libBsrc/libB.so and there's no problem. During staging phase however libtool relinks libA with "-L${STAGEDIR}${PREFIX}/lib -lB". It is important that this -L option precedes other -L options like -L${LOCALBASE}/lib, otherwise a pre-installed libB might be linked in instead of the freshly built one. Somewhat simplified the linker command line looks like: ${CC} ${src_LDFLAGS} ${LDFLAGS} ${src_LIBS} ${LIBS} where src_LDFLAGS and src_LIBS are controlled by upstream and LDFLAGS and LIBS can be controlled by us. Normally "../libBsrc/libB.la" would be part of src_LIBS which means we need to put flags like -L${LOCALBASE}/lib in LIBS instead of LDFLAGS like most ports currently do. Some ports already use LIBS. The attached patch improves support for that. - Add LIBS=${LIBS} to MAKE_ENV and CONFIGURE_ENV. - Add an option helper for LIBS. - Add a sanity check for LDFLAGS containing -L and/or -l options. (Currently only when GNU_CONFIGURE is defined.) - While here, add a sanity check for CFLAGS containing -D and/or -I options. (Currently only when GNU_CONFIGURE is defined.) - Adjust all ports that already use LIBS. Also remove references to PTHREAD_CFLAGS and PTHREAD_LIBS while here.