Bug 190664

Summary:	Commit Ready status needs tweaking
Product:	Services	Reporter:	Bryan Drewery <bdrewery>
Component:	Bug Tracker	Assignee:	Bugmeister <bugmeister>
Status:	Closed Overcome By Events
Severity:	Affects Only Me
Priority:	---
Version:	unspecified
Hardware:	Any
OS:	Any
Bug Depends on:
Bug Blocks:	190477

Description Bryan Drewery freebsd_committer

2014-06-05 19:24:00 UTC

Commit Ready is a bit deceiving. I assume once a maintainer approves a patch we move it to this status. But stop, it's not ready for commit. It needs further testing by the committer. I don't think I'm being pedantic here as there may be patches in PR that truly are *ready for commit* and just need someone to pull the trigger on it, or perhaps it's ready/tested and just waiting on further work to be committed.

Comment 1 Eitan Adler freebsd_committer

2014-06-08 23:06:38 UTC

Hm.  I think that maintainer approval doesn't belong in the state machine.  "Commit ready" is meant to mean "The issue is known, and there is a patch that should fix the issue".  I agree that 'Commit Ready' does not well explain this.  Any suggestion for a new name?

Comment 2 Marcus von Appen freebsd_committer

2014-09-20 08:14:08 UTC

The issue is not relevant anymore. We've got patch ready, which's a bit better.