Bug 190828

Summary: [maintainer] [stage] net/openmq - update, stage support, optionsNg support
Product: Ports & Packages Reporter: Radim Kolar <hsn>
Component: Individual Port(s)Assignee: Jonathan Chu <milki>
Status: Closed FIXED    
Severity: Affects Many People CC: milki
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
port diff
none
openmq-client diff none

Description Radim Kolar 2014-06-09 11:58:12 UTC 
Created attachment 143561 [details]
port diff

update to 4.5.2.p1
add stage support
add port options ng support
Comment 1 Radim Kolar 2014-06-09 12:00:29 UTC 
Created attachment 143562 [details]
openmq-client diff

support stage for client port too
Comment 2 Jonathan Chu freebsd_committer freebsd_triage 2014-06-10 05:36:08 UTC 
I'll take this.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2014-06-10 06:16:33 UTC 
Correct Synopsis.
Comment 4 Jonathan Chu freebsd_committer freebsd_triage 2014-06-14 16:03:46 UTC 
The commit is being reviewed by my mentors.
Comment 5 Jonathan Chu freebsd_committer freebsd_triage 2014-06-19 15:53:35 UTC 
The patch is approved. I've add a minor change to remove PORT_OPTIONS:MDOCS and PORT_OPTIONS:MEXAMPLES conditionals since they aren't needed and added %%PORTEXAMPLES%%.

There's only one comment:

    @cd ${WRKSRC}/dist/mq && ${FIND} etc -depth 1 -type f -print | \
	      ${ECHO_CMD} "etc/mq/{}" \; >> ${PLIST}
		​      ${SED} -e "\-/-s--/mq/-" >> ${PLIST}

This regex seems overly complicated. Would 's|/|/mq/|' be enough?
Comment 6 Radim Kolar 2014-06-21 16:31:37 UTC 
i dont know. i am not sed expert
Comment 7 Jonathan Chu freebsd_committer freebsd_triage 2014-06-22 04:56:31 UTC 
(In reply to hsn from comment #6)
> i dont know. i am not sed expert

Can you explain your intention with the sed then?

It appears to replace existing '/' at the beginning of the file path with '/mq/'. Is this correct?
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-06-22 05:07:22 UTC 
A commit references this bug:

Author: milki
Date: Sun Jun 22 05:06:24 UTC 2014
New revision: 358766
URL: http://svnweb.freebsd.org/changeset/ports/358766

Log:
  Update net/openmq and net/openmq-client to 4.5.2.p.1

  - StageDir support
  - Added DOCS and EXAMPLES options

  Changelog: https://mq.java.net/4.5.2.html

  PR:		190828
  Submitted by:	hsn@sendmail.cz
  Approved by:	swills (mentor)

Changes:
  head/net/openmq/Makefile
  head/net/openmq/distinfo
  head/net/openmq/pkg-descr
  head/net/openmq-client/Makefile
Comment 9 Jonathan Chu freebsd_committer freebsd_triage 2014-06-26 05:14:25 UTC 
Thanks! Committed with minor changes.