Bug 190847

Summary: [PATCH] Mk/bsd.python.mk: PYTHON_PY3K_PLIST_HACK: Take @dirrmtry entries into account as well.
Product: Ports & Packages Reporter: Raphael Kubo da Costa <rakuco>
Component: Ports FrameworkAssignee: freebsd-python (Nobody) <python>
Status: Closed FIXED    
Severity: Affects Some People CC: koobs, mva
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 180467    
Attachments:
Description Flags
Proposed patch
none
Patch v2 none

Description Raphael Kubo da Costa freebsd_committer 2014-06-09 21:15:52 UTC
Created attachment 143581 [details]
Proposed patch

This was first sent to Phabricator (https://phabric.freebsd.org/D191), so trying here as well.

When using the plist hack to add __pycache__ entries for Python >= 3.2.0, take
@dirrmtry entries into account as well, otherwise if those directories happen
to contain __pycache__ subdirectories the latter will not be removed.
Comment 1 Raphael Kubo da Costa freebsd_committer 2014-06-13 20:04:40 UTC
Created attachment 143752 [details]
Patch v2

Sync patch with the version in Phabricator, as updating the bug here seems to be the easiest way to trigger activity there...
Comment 2 commit-hook freebsd_committer 2014-06-18 19:38:21 UTC
A commit references this bug:

Author: rakuco
Date: Wed Jun 18 19:37:50 UTC 2014
New revision: 358308
URL: http://svnweb.freebsd.org/changeset/ports/358308

Log:
  PYTHON_PY3K_PLIST_HACK: Take @dirrmtry entries into account as well.

  When using the plist hack to add __pycache__ entries for Python >= 3.2.0,
  take @dirrmtry entries into account as well, otherwise if those directories
  happen to contain __pycache__ subdirectories the latter will not be removed.

  CR:		D191
  PR:		190847

Changes:
  head/Mk/bsd.python.mk
Comment 3 commit-hook freebsd_committer 2014-06-21 16:48:37 UTC
A commit references this bug:

Author: rakuco
Date: Sat Jun 21 16:48:02 UTC 2014
New revision: 358717
URL: http://svnweb.freebsd.org/changeset/ports/358717

Log:
  MFH: r358308

  PYTHON_PY3K_PLIST_HACK: Take @dirrmtry entries into account as well.

  When using the plist hack to add __pycache__ entries for Python >= 3.2.0,
  take @dirrmtry entries into account as well, otherwise if those directories
  happen to contain __pycache__ subdirectories the latter will not be removed.

  CR:		D191
  PR:		190847

  Approved by:	portmgr (erwin)

Changes:
_U  branches/2014Q2/
  branches/2014Q2/Mk/bsd.python.mk