Bug 190954
| Summary: | [patch] Added stage support to www/tikiwiki | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | joe | ||||
| Component: | Individual Port(s) | Assignee: | John Marino <marino> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | marino | ||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
This port built cleanly, but when I looked closely I spotted some problems: 1) The installation is muted with (@). That was in the original makefile and it's wrong 2) The "-" prefix for mkdir command is unnecessary. It will never fail 3) The "cp -R" technique is not allowed, use COPYTREE for entire directory copy 4) The ownership / group stuff needs to happen in the pkg-plist, not in stage. Again this was in the original but it needed to be changed and it wasn't. the plist is over 15,000 lines, 1.1Mb! Seems to be a candidate for autogenerated plist This port has a custom extract target, and the arguments are -yxf. -y is for tar.bz2, but this is a tar.gz file! Apparently tar is just handling it, but it's really an error. And I doubt it needs a custom target. A commit references this bug: Author: marino Date: Fri Jun 13 20:06:35 UTC 2014 New revision: 357720 URL: http://svnweb.freebsd.org/changeset/ports/357720 Log: www/tikiwiki: Add Stage support, switch to autogen pkg list PR: 190954 Submitted by: Joe Benden The stage PR worked, but there were existing problems that weren't fixed, such as muted install commands, "cp -r" instead of install macros, the use of "-" prefix on commands that won't fail. A list of additional, "while we are here changes": * 16,000+ line, 1.1Mb pkg-plist removed, autogen instead * Remove now-unnecessary x-generate-plist maintainer target * Remove PLIST_SUB lines * Remove unnecessary roll-your-own extract target. Leave one original deletion as a post-extract target * Use COPYTREE_SHARE instead of "cp -r" * move CHOWN operations to pkg-plist generation Changes: head/www/tikiwiki/Makefile head/www/tikiwiki/pkg-plist |
Created attachment 143698 [details] Added stage support to tikiwiki Added stage support to www/tikiwiki.