Bug 190983

Summary: [PATCH] Let x11/pixman build with clang on ARM
Product: Ports & Packages Reporter: Andrew Turner <Andrew>
Component: Individual Port(s)Assignee: freebsd-x11 (Nobody) <x11>
Status: Closed FIXED    
Severity: Affects Some People CC: sbruno
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Fix on ARM with clang
none
redports diff none

Description Andrew Turner freebsd_committer freebsd_triage 2014-06-12 22:08:18 UTC
Created attachment 143723 [details]
Fix on ARM with clang

I have been testing building ports on ARM using the armv6hf target. I found pixman fails to build as it includes float.h in a header included from assembly files.

The attached patch moves this header in with the others so it won't be included from asm.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-06-13 04:42:07 UTC
Over to maintainers.
Comment 2 Sean Bruno freebsd_committer freebsd_triage 2014-07-05 23:00:27 UTC
Test build on redports show's no issues with this for amd64/i386.

I'll apply this after portmgr review.
Comment 3 Sean Bruno freebsd_committer freebsd_triage 2014-07-05 23:00:53 UTC
Created attachment 144438 [details]
redports diff
Comment 5 Sean Bruno freebsd_committer freebsd_triage 2014-07-05 23:01:56 UTC
this blocks 2k or so ports building for ARMv6
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-07-05 23:21:50 UTC
A commit references this bug:

Author: sbruno
Date: Sat Jul  5 23:21:47 UTC 2014
New revision: 360840
URL: http://svnweb.freebsd.org/changeset/ports/360840

Log:
  Move include of float.h to enable build on armv6

  PR:		190983
  Submitted by:	andrew@freebsd.org
  Reviewed by:	mat@freebsd.org

Changes:
  head/x11/pixman/Makefile
  head/x11/pixman/files/
  head/x11/pixman/files/patch-pixman-private.h