Bug 191029

Summary: [patch] systuils/screen: 4.2.1_2 breaks access to sessions to previous portrevsisions
Product: Ports & Packages Reporter: Lawrence Chen <beastie>
Component: Individual Port(s)Assignee: Cy Schubert <cy>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Make being backward compatible to 4.0 an option none

Description Lawrence Chen 2014-06-14 13:05:49 UTC
Created attachment 143771 [details]
Make being backward compatible to 4.0 an option

screen-4.2.1_2 can't find my screen sessions any more.

# pkg info -E screen
screen-4.2.1_1
# screen -ls
There are screens on:
        18332.prts2     (Attached)
        72554.ports     (Attached)
2 Sockets in /tmp/screens/S-root.
# pkg upgrade
...
# pkg info E screen
screen-4.2.1_2
# screen -ls
No Sockets found in /tmp/screens/S-root.
# ls -al /tmp/screens/S-root
total 8
drwx------  2 root  wheel  512  9 Jun 11:28 .
drwxr-xr-x  3 root  wheel  512  5 Jun 21:14 ..
srwx------  1 root  wheel    0  5 Jun 21:14 2508.prts2
srwx------  1 root  wheel    0  9 Jun 11:28 86107.ports

Yes, it was annoying when 4.2.1 came out on April 30th that my existing screen sessions were lost.  But, there has been plenty of time to get over the loss, especially since there have been (at least for me, two reboots due to kernel updates from freebsd-update.  I did 9.2-RELEASE-p6 on May 18th, and 9.2-RELEASE-p7 on June 5th for my two core servers.)

If being able to find pre-existing 4.0 sessions is so important, at this point it should be an option to not break things for the rest of us.

Since the application is mutual exclusive on whether its doing sockets or fifos for functions in its file named 'sockets.c'.
Comment 1 Lawrence Chen 2014-06-14 20:20:25 UTC
In digging around in the screen git repository....the change to favor sockets over fifos was committed on 12/19/2005.  With the commit that set the release to be 4.0.3, that we thought we've been using on 10/23/2006.

But, the configure.in file in the 4.0.3 source archive has a timestamp of 06/03/2003.  The archive contains most files in the range 04/28/2001 to 12/05/2003 with a jump to 10/23/2006.

So, our 4.0.3 was being configured using 4.0.0's configure script, missing 3 commits that had been done to it leading to 4.0.3.  There had been no change to configure.in between 4.0.0 and 4.0.2.

The first change to configure.in was to address a security problem, though from the diff it was to detect the need do something different on SVR4-based systems.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2014-06-15 04:06:08 UTC
Over to maintainer.
Comment 3 Cy Schubert freebsd_committer freebsd_triage 2014-06-15 05:28:07 UTC
Options committed.