Summary: | [patch] graphics/libvisual04: Fix warning in installed header | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Koop Mast <kwm> | ||||
Component: | Individual Port(s) | Assignee: | Chris Rees <crees> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | ||||||
Priority: | --- | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Koop Mast
2014-06-19 15:54:11 UTC
Created attachment 143930 [details]
Fix installed headers issues with clang.
OK, I'm officially confused :) Your patch has a tiny bit of patch in it, which doesn't do anything, and the referenced commit doesn't apply properly, and when massaged in, clang still complains about redefining NULL! Have I missed something? Chris The patch is needed to "fix" the following error: make[3]: Entering directory `/usr/home/kwm/cvs/freedesktop/gst-plugins-base/ext/libvisual' CC libgstlibvisual_la-plugin.lo In file included from plugin.c:25: In file included from ./visual.h:29: In file included from /usr/local/include/libvisual-0.4/libvisual/libvisual.h:29: In file included from /usr/local/include/libvisual-0.4/libvisual/lv_bits.h:28: /usr/local/include/libvisual-0.4/libvisual/lv_defines.h:68:10: error: '__packed' macro redefined [-Werror] # define __packed __attribute__ ((packed)) ^ /usr/include/sys/cdefs.h:230:9: note: previous definition is here #define __packed __attribute__((__packed__)) ^ 1 error generated. gmake[3]: *** [libgstlibvisual_la-plugin.lo] Error 1 (In reply to Chris Rees from comment #2) > OK, I'm officially confused :) > > Your patch has a tiny bit of patch in it, which doesn't do anything, and the > referenced commit doesn't apply properly, and when massaged in, clang still > complains about redefining NULL! > > Have I missed something? > > Chris Yeah the reference commit doesn't apply. But the changes are good enough. A commit references this bug: Author: crees Date: Fri Jun 27 20:46:59 UTC 2014 New revision: 359607 URL: http://svnweb.freebsd.org/changeset/ports/359607 Log: Apply patch from upstream to fix a warning. This allows build of the gstreamer1 libvisual plugin with -Werror. PR: ports/191189 Submitted by: kwm Changes: head/graphics/libvisual04/Makefile head/graphics/libvisual04/files/patch-libvisual-lv_defines.h head/graphics/libvisual04/files/patch-libvisual-lv_mem.h head/graphics/libvisual04/pkg-plist |