Bug 19130

Summary: make reports Makefile error if USA_RESIDENT not set
Product: Base System Reporter: Vivek Khera <khera>
Component: miscAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 3.4-STABLE   
Hardware: Any   
OS: Any   

Description Vivek Khera 2000-06-08 20:10:00 UTC
	
gnupg-rsa port fails with Makefile error if USA_RESIDENT is unset.

Fix: 

workaround is to set USA_RESIDENT environment variable.
How-To-Repeat: 
	
unsetenv USA_RESIDENT (and make sure not set in /etc/make.conf)
cd /usr/ports/security/gnupg-rsa
make

The error is this:

[root@onceler]# make
"Makefile", line 30: Malformed conditional (${USA_RESIDENT} == NO)
"Makefile", line 30: Need an operator
"Makefile", line 34: if-less else
"Makefile", line 34: Need an operator
"Makefile", line 39: if-less endif
"Makefile", line 39: Need an operator
make: fatal errors encountered -- cannot continue
[root@onceler]# ident Makefile
Makefile:
     $FreeBSD: ports/security/gnupg-rsa/Makefile,v 1.2 2000/05/15 06:33:36 kuriyama Exp $
[root@onceler]#
Comment 1 Jeroen Ruigrok van der Werven freebsd_committer freebsd_triage 2000-06-10 12:37:29 UTC
Responsible Changed
From-To: gnats-admin->freebsd-bugs

Misfiled PR.
Comment 2 Johan.Karlsson 2000-08-02 15:30:40 UTC
Hi Vivek

Setting USA_RESIDENT is mandantory for this port, but you should not get
that 
error any way.

Using FreeBSD 4.2-Stable and with the new Makefile of this port it 
seems to work.

k@numeri /usr/ports/security/gnupg-rsa >ident Makefile
Makefile:
     $FreeBSD: ports/security/gnupg-rsa/Makefile,v 1.3 2000/07/04
02:44:57 kuriyama Exp $

I think this was solved in rev 1.3 but it might be that FreeBSD
3.4-STABLE
has some minor differens in its 'make' and if so this needs to be dealt
with.

Can you please update your ports-tree and try this again.


Thanks 
Johan K

-- 
Johan Karlsson              Phone : +46 (0)920 720 16 
Systemteknik, Datalogi      Fax   : +46 (0)920 721 91 
Luleå Tekniska Universitet  E-mail: Johan.Karlsson@SM.LuTH.SE
S-971 87 LULEÅ, SWEDEN
Comment 3 Sheldon Hearn 2000-08-02 15:44:53 UTC
On Wed, 02 Aug 2000 07:40:03 MST, Johan Karlsson wrote:

>  I think this was solved in rev 1.3 but it might be that FreeBSD
>  3.4-STABLE has some minor differens in its 'make' and if so this
>  needs to be dealt with.

I don't think so.  The Makefile rev 1.3 still contains:

.if ${USA_RESIDENT} == NO
[...]

Ciao,
Sheldon.
Comment 4 Sheldon Hearn 2000-08-02 15:47:46 UTC
On Wed, 02 Aug 2000 16:44:53 +0200, Sheldon Hearn wrote:

> >  I think this was solved in rev 1.3 but it might be that FreeBSD
> >  3.4-STABLE has some minor differens in its 'make' and if so this
> >  needs to be dealt with.
> 
> I don't think so.  The Makefile rev 1.3 still contains:
> 
> .if ${USA_RESIDENT} == NO
> [...]

Hmm, I failed to notice that the ``.if ${USA_RESIDENT} == NO'' is inside
an ``.elif defined(USA_RESIDENT)''.  I'll take a look.

Ciao,
Sheldon.
Comment 5 Vivek Khera 2000-08-02 15:51:02 UTC
>>>>> "JK" == Johan Karlsson <Johan.Karlsson@sm.luth.se> writes:

JK> k@numeri /usr/ports/security/gnupg-rsa >ident Makefile
JK> Makefile:
JK>      $FreeBSD: ports/security/gnupg-rsa/Makefile,v 1.3 2000/07/04
JK> 02:44:57 kuriyama Exp $

JK> I think this was solved in rev 1.3 but it might be that FreeBSD
JK> 3.4-STABLE
JK> has some minor differens in its 'make' and if so this needs to be dealt
JK> with.

Yes; the current makefile does properly report that USA_RESIDENT must
be set.  This is on 3.5-STABLE.  The bug is resolved.


[root@onceler]# ident Makefile
Makefile:
     $FreeBSD: ports/security/gnupg-rsa/Makefile,v 1.3 2000/07/04 02:44:57 kuriyama Exp $
[root@onceler]# make

You must set variable USA_RESIDENT to YES, if you are USA resident
or to NO, if you aren't USA resident to build this package
*** Error code 1

Stop.
Comment 6 Sheldon Hearn freebsd_committer freebsd_triage 2000-08-02 16:11:24 UTC
State Changed
From-To: open->closed

Yet another close-pr courtesy of 
Johan Karlsson <Johan.Karlsson@sm.luth.se>.