Bug 191306
| Summary: | [vt] VT using inconsistent token parameters to kbd_allocate() and kbd_release() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | jau789 | ||||
| Component: | kern | Assignee: | Aleksandr Rybalko <ray> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | emaste | ||||
| Priority: | Normal | ||||||
| Version: | 10.0-STABLE | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: ray Date: Wed Jul 9 14:36:04 UTC 2014 New revision: 268460 URL: http://svnweb.freebsd.org/changeset/base/268460 Log: Fix inconsistent token parameters for kbd_allocate() and kbd_release() in vt(4). PR: 191306 Submitted by: jau789@gmail.com Sponsored by: The FreeBSD Foundation Changes: head/sys/dev/vt/vt_core.c (In reply to jau789 from comment #0) > Created attachment 144065 [details] > make VT consistently use a pointer to struct vt_device > > VT has been using inconsistent token parameters while calling > kbd_allocate() and kbd_release() mixing keyboard ID and a pointer > to struct vt_device. > This has caused e.g. "kbdcontrol -K" to fail. > > The attached patch should fix the issue. Many thanks for pointing that!!! Changes reviewed and committed. Does this need MFC? A commit references this bug: Author: emaste Date: Mon Jul 21 14:31:58 UTC 2014 New revision: 268941 URL: http://svnweb.freebsd.org/changeset/base/268941 Log: MFC r268460 by ray: Fix inconsistent token parameters for kbd_allocate() and kbd_release() in vt(4). PR: 191306 Submitted by: jau789 at gmail.com Sponsored by: The FreeBSD Foundation Changes: _U stable/10/ stable/10/sys/dev/vt/vt_core.c A commit references this bug: Author: emaste Date: Mon Jul 21 14:36:36 UTC 2014 New revision: 268942 URL: http://svnweb.freebsd.org/changeset/base/268942 Log: MFC r268460 by ray: Fix inconsistent token parameters for kbd_allocate() and kbd_release() in vt(4). PR: 191306 Submitted by: jau789 at gmail.com Sponsored by: The FreeBSD Foundation Changes: _U stable/9/sys/ _U stable/9/sys/dev/ stable/9/sys/dev/vt/vt_core.c |
Created attachment 144065 [details] make VT consistently use a pointer to struct vt_device VT has been using inconsistent token parameters while calling kbd_allocate() and kbd_release() mixing keyboard ID and a pointer to struct vt_device. This has caused e.g. "kbdcontrol -K" to fail. The attached patch should fix the issue.