Bug 191338
| Summary: | [PATCH] devel/boehm-gc: update to 7.4.2 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Carlos J Puga Medina <cjpm> | ||||||
| Component: | Individual Port(s) | Assignee: | Adam Weinberger <adamw> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | adamw | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Any update on this? I'll take this. Couple issues. 1) Do we really need to install .la files? Why not just add USES=libtool? Additionally, USE_AUTOTOOLS=libtool is deprecated; you can USE_LIBTOOL=aclocal autoconf libtoolize instead. 2) Packaging is broken with DOCS disabled. (check make check-plist) 3) Rather than stripping things manually in post-install:, could you just set INSTALL_TARGET=install-strip? That works for many autoconf ports... Oh, and 4) What is up with your patch? --- Makefile.orig 2014-06-22 21:11:08.000000000 +0200 +++ Makefile.orig 2014-06-22 22:17:25.000000000 +0200 When the to/from are both labelled "Makefile.orig" it means I have to manually edit the patch before it'll apply to the sources in the ports tree. Created attachment 144510 [details]
boehm-gc-7.4.2.diff
Thanks for check it. It was fixed!
A commit references this bug: Author: adamw Date: Tue Jul 8 20:00:46 UTC 2014 New revision: 361286 URL: http://svnweb.freebsd.org/changeset/ports/361286 Log: Update to 7.4.2, and pass maintainership to submitter. PR: 191338 Submitted by: Carlos Jacobo Puga Medina Changes: head/devel/boehm-gc/Makefile head/devel/boehm-gc/distinfo head/devel/boehm-gc/pkg-plist Thank you for reworking the patch! Committed with just a small modification to the documentation installation section. |
Created attachment 144096 [details] boehm-gc-7.4.2.diff - Update to 7.4.2 - Add dependency on libatomics_ops - Fix LICENSE - Fix pkg-plist - Take maintainership