Bug 191383

Summary: New port: net-mgmt/victorops-nagios Nagios integration for VictorOps incident notification service
Product: Ports & Packages Reporter: Douglas K. Rand <doug.rand>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: doug.rand, marino, pi
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.shar
none
Poudriere log
none
Results of poudriere testport
none
Updtaed SHAR with pkg-plist fixed and pkg-message added. none

Description Douglas K. Rand 2014-06-25 22:04:00 UTC
Created attachment 144132 [details]
file.shar

VictorOps is an on-call management and incident notification service.
	This is the Nagios/Icinga integration package for VictorOps.
	WWW: http://www.victorops.com

	The port also includes a patch to fall back to qpage if an alert
	fails to be delivered to the VictorOps service. A nice feature if 
	the alert is about your Internet service falling down.

How-To-Repeat:
Be a VictorOps customer using Nagios or Icinga and find yourself
	a bit frustrated with the Linuxisms in the shell scripts.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-07-31 16:05:38 UTC
Can you provide test logs from poudriere or redports or at least the output from "make check-plist" followed by "make stage-qa" ?
Comment 2 Douglas K. Rand 2014-07-31 16:27:37 UTC
Created attachment 145188 [details]
Poudriere log

The requested Poudriere log
Comment 3 Douglas K. Rand 2014-07-31 16:28:04 UTC
(In reply to John Marino from comment #1)
> Can you provide test logs from poudriere or redports or at least the output
> from "make check-plist" followed by "make stage-qa" ?

Just attached it to the ticket, I hope this is what you were looking for.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-07-31 16:31:04 UTC
It was, but unfortunately I was too vague.

You should use either "poudriere testport" or "poudriere bulk -t" so it does the QA tests.   Now I have to go back to a bunch of PRs and clarify that since I cut and pasted the same request.

Anyway, your log doesn't do the extra stage-qa tests which is what we are looking for.
Comment 5 Douglas K. Rand 2014-08-07 16:18:35 UTC
Created attachment 145452 [details]
Results of poudriere testport

Attached is the results of poudriere's testport. The first run did find 2
check-plist errors, that I'm not sure are valid, but I added to pkg-plist
anyway to clear the errors:

Error: Orphaned: @dirrmtry etc/periodic/daily
Error: Orphaned: @dirrmtry etc/periodic

I'll update the shar file attachement in a minute.
Comment 6 Douglas K. Rand 2014-08-07 16:24:50 UTC
Created attachment 145453 [details]
Updtaed SHAR with pkg-plist fixed and pkg-message added.

An updated shar file for victorops-nagios. It has 2 changes:

Added two lines to pkg-plist:

@dirrmtry etc/periodic/daily
@dirrmtry etc/periodic

to silence errors from pkg-plist.

I also added pkg-message to indicate that ca_root_nss requires the ETCSYMLINK option in order for wget to be able to check VictorOps' GoDaddy certificate. I'm unsure if I should add

RUN_DEPENDS+= /etc/ssl/cert.pem:${PORTSDIR}/security/ca_root_nss

as if it is built with out the option then the build will fail since the package is already installed. It seems like an inelegant solution. I have left this out not liking the approach.
Comment 7 John Marino freebsd_committer freebsd_triage 2014-08-07 16:48:50 UTC
Thanks, it looks patch-ready now.
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-08-09 09:50:51 UTC
A commit references this bug:

Author: pi
Date: Sat Aug  9 09:49:52 UTC 2014
New revision: 364420
URL: http://svnweb.freebsd.org/changeset/ports/364420

Log:
  New port: net-mgmt/victorops-nagios

  VictorOps is an on-call management and incident notification service.
  This is the Nagios/Icinga integration package for VictorOps.

  WWW: http://www.victorops.com

  PR:		191383
  Submitted by:	rand@iteris.com

Changes:
  head/net-mgmt/Makefile
  head/net-mgmt/victorops-nagios/
  head/net-mgmt/victorops-nagios/Makefile
  head/net-mgmt/victorops-nagios/distinfo
  head/net-mgmt/victorops-nagios/files/
  head/net-mgmt/victorops-nagios/files/patch-check_victorops_cmds
  head/net-mgmt/victorops-nagios/files/patch-check_victorops_forwarder
  head/net-mgmt/victorops-nagios/files/patch-do_victorops_heartbeat
  head/net-mgmt/victorops-nagios/files/patch-enqueue_alert
  head/net-mgmt/victorops-nagios/files/patch-forward_alerts
  head/net-mgmt/victorops-nagios/files/patch-support_collect.sh
  head/net-mgmt/victorops-nagios/files/patch-utils
  head/net-mgmt/victorops-nagios/files/patch-victorops.cron
  head/net-mgmt/victorops-nagios/files/qpage-patch
  head/net-mgmt/victorops-nagios/pkg-descr
  head/net-mgmt/victorops-nagios/pkg-message
  head/net-mgmt/victorops-nagios/pkg-plist
Comment 9 Kurt Jaeger freebsd_committer freebsd_triage 2014-08-09 09:54:12 UTC
Committed, thanks.