Bug 191388

Summary: net-mgmt/collectd network interfaces plugin does not work properly, spams "uc_update: Value too old:" in the log.
Product: Ports & Packages Reporter: Fredrik Lennmark <fredrik>
Component: Individual Port(s)Assignee: John Marino <marino>
Status: Closed FIXED    
Severity: Affects Some People CC: marino, ports
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
net-mgmt-collectd.patch none

Description Fredrik Lennmark 2014-06-26 08:14:07 UTC 
Collectd network interfaces plugin does not work properly, spams "uc_update: Value too old:" in the log.

This issue was fixed for /usr/ports/net-mgmt/collectd5 with this patch: http://svnweb.freebsd.org/ports/head/net-mgmt/collectd5/files/patch-src-interface.c?view=markup&pathrev=338750

I've tried the same patch for /usr/ports/net-mgmt/collectd and it works.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-07-04 01:42:39 UTC 
Notify maintainer.
Comment 2 Krzysztof 2014-07-05 09:18:58 UTC 
Created attachment 144419 [details]
net-mgmt-collectd.patch

Proposed patch to resolve issue with uc_update
Comment 3 Krzysztof 2014-07-05 09:19:59 UTC 
Ok, thank a lot for your help with this issue. I've made a patch to correct this problem (attached). So I hope it will be resolved soon.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-07-20 16:09:39 UTC 
maintainer created a fix, so it can be committed now.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-07-27 01:19:15 UTC 
ports@bsdserwis.com:

I think the attached patch is corrupt.  All it does is bump the portrevision; surely there is more to your fix?
Comment 6 Krzysztof 2014-07-27 15:07:10 UTC 
Hmm,

I don't think so that patch only bumps portrevision :-))) I've checked my ports collection again and there is no patch-src__interface.c actually. So attached patch has also this "missing" file. Or am I wrong? :-)))
Comment 7 John Marino freebsd_committer freebsd_triage 2014-07-27 15:09:42 UTC 
(In reply to ports from comment #6)
> Hmm,
> 
> I don't think so that patch only bumps portrevision :-))) I've checked my
> ports collection again and there is no patch-src__interface.c actually. So
> attached patch has also this "missing" file. Or am I wrong? :-)))

Yes.
Look at the patch on bugzilla.  It's easily verifiable. (click the "diff" hyperlink)
Comment 8 John Marino freebsd_committer freebsd_triage 2014-10-05 22:07:31 UTC 
The last comment was before I realized bugzilla diff viewer was (and still is) buggy.  I'll take it since it's my fault the PR got stalled.
Comment 9 commit-hook freebsd_committer freebsd_triage 2014-10-05 23:26:46 UTC 
A commit references this bug:

Author: marino
Date: Sun Oct  5 23:25:48 UTC 2014
New revision: 370134
URL: https://svnweb.freebsd.org/changeset/ports/370134

Log:
  net-mgmt/collectd: Fix network IF plugin to avoid log spam

  While here, remove redundant @dirrm and strip installed libraries.

  PR:		191388
  Reported by:	Fredrik Lennmark
  Fix by:		maintainer (Krzysztof Stryjek)

Changes:
  head/net-mgmt/collectd/Makefile
  head/net-mgmt/collectd/files/patch-src__interface.c
  head/net-mgmt/collectd/pkg-plist
Comment 10 John Marino freebsd_committer freebsd_triage 2014-10-05 23:27:13 UTC 
Thanks!