Bug 191446

Summary: [Maintainer update] security/p5-openxpki-i18n to ver 0.14.0.1
Product: Ports & Packages Reporter: Sergei Vyshenski <svysh.fbsd>
Component: Individual Port(s)Assignee: William Grzybowski <wg>
Status: Closed FIXED    
Severity: Affects Some People CC: miwi, svysh.fbsd, wg
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 191444    
Bug Blocks:    
Attachments:
Description Flags
patch for updating port
none
A patch to be added to the "files" directory within a port
none
To be added to the "files" directory within a port
none
aggregated new patch for updating port svysh.fbsd: maintainer-approval+

Description Sergei Vyshenski 2014-06-27 20:32:55 UTC
Created attachment 144206 [details]
patch for updating port

- Update to ver 0.14.0.1

- Follow LICENSE change of the original software.

- Switch MASTER_SITES from SF to GH.

This patch has passed tests on FreeBSD-10.0 (i386) with:

- port test
- poudriere testport ...
Comment 1 William Grzybowski freebsd_committer freebsd_triage 2014-08-03 12:18:57 UTC
Hi,

I cannot get this to build with a 10-amd64.


ru_RU/openxpki.po:503: end-of-file within string
msgmerge: found 1 fatal error
gmake[2]: *** [ru_RU/openxpki.po] Error 1
gmake[2]: *** Waiting for unfinished jobs....
ru_RU/openxpki.po:78: warning: internationalized messages should not contain the '\r' escape sequence
ru_RU/openxpki.po:78: warning: internationalized messages should not contain the '\r' escape sequence
ru_RU/openxpki.po:78: warning: internationalized messages should not contain the '\r' escape sequence
ru_RU/openxpki.po:78: warning: internationalized messages should not contain the '\r' escape sequence
ru_RU/openxpki.po:87: warning: internationalized messages should not contain the '\r' escape sequence
ru_RU/openxpki.po:87: warning: internationalized messages should not contain the '\r' escape sequence
ru_RU/openxpki.po:87: warning: internationalized messages should not contain the '\r' escape sequence
ru_RU/openxpki.po:87: warning: internationalized messages should not contain the '\r' escape sequence
gmake[2]: Leaving directory `/wrkdirs/usr/ports/security/p5-openxpki-i18n/work/openxpki-openxpki-66ee052/core/i18n'
gmake[1]: *** [scan] Error 2
gmake[1]: *** Waiting for unfinished jobs...
Comment 2 Sergei Vyshenski 2014-08-03 13:07:06 UTC
Hi,

1. As for 

> ru_RU/openxpki.po:503: end-of-file within string
> msgmerge: found 1 fatal error
> gmake[2]: *** [ru_RU/openxpki.po] Error 1
> gmake[2]: *** Waiting for unfinished jobs....

File ru_RU/openxpki.po is a simple text file and I do not see any EOF symbols inside it.
Neither can I reproduce this error on my 10-amd64 system. 
Nobody from our openxpki community has ever complained about this pretty old file.

Can it be, that your gmake is configured so, that it tries to process this file in parallel or such? I mean those message about "unfinished jobs".

2. Warnings about "\r" symbols can be safely ignored.

All the best, Sergei
Comment 3 William Grzybowski freebsd_committer freebsd_triage 2014-08-03 14:31:15 UTC
I am using:

poudriere testport -j 10x64 -s -o security/p5-openxpki-i18n
Comment 4 Sergei Vyshenski 2014-08-03 17:46:46 UTC
Please let me to investigate for a couple of days.
If nothing helps, we can include .mo files with the distribution.
Comment 5 Sergei Vyshenski 2014-08-04 17:39:59 UTC
Created attachment 145368 [details]
A patch to be added to the "files" directory within a port

Hi Williams,

Please add a file patch-ru_RU__openxpki.po (located inside files.zip attached herewith) to the "files" directory within a port.

It is supplied IN ADDITION to the initial patch, submitted with PR.

Please test again with this file in place.
Sorry I still can not reproduce that fatal error, which you indicate.
This file performs some general sanitary format cleaning of the affected file ru_RU/openxpki.po

All the best, Sergei
Comment 6 Sergei Vyshenski 2014-08-04 17:42:30 UTC
Created attachment 145369 [details]
To be added to the "files" directory within a port
Comment 7 Sergei Vyshenski 2014-08-04 18:08:44 UTC
Hi William,

At last I reproduced the reported error. 
Working on it.
Please disregard my previous 2 comments.

All the best, Sergei
Comment 8 Sergei Vyshenski 2014-08-04 20:54:42 UTC
Hi William,

Yes, I reproduced the fatal error which you found. It appears only on multiprocessor amd64 architecture, and really is related to parallel builds.
By the way it complains in plain English:

===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.

So, the problem is fixed by editing of a port's Makefile as follows. Before existing line:

USES=gettext gmake perl5

it is necessary to add a new line:

MAKE_JOBS_UNSAFE=yes

This should be done after applying the very first patch submitted with this PR.
My second and third patches should be ignored.

Shall I prepare and upload a new aggregated patch, or you could kindly add a line about MAKE_JOBS_UNSAFE=yes to the Makefile?

All the best, Sergei
Comment 9 Sergei Vyshenski 2014-08-05 09:15:28 UTC
Created attachment 145386 [details]
aggregated new patch for updating port

This aggregated new patch does everything: updating the port and fixing fatal errors on multiprocessor amd64. 

Tested with poudriere.
Comment 10 commit-hook freebsd_committer freebsd_triage 2014-08-05 14:10:58 UTC
A commit references this bug:

Author: wg
Date: Tue Aug  5 14:10:26 UTC 2014
New revision: 364102
URL: http://svnweb.freebsd.org/changeset/ports/364102

Log:
  security/p5-openxpki-i18n: update to 0.14.0.1

  - Follow LICENSE change of the original software.
  - Switch MASTER_SITES from SF to GH.

  PR:		191446
  Submitted by:	maintainer

Changes:
  head/security/p5-openxpki-i18n/Makefile
  head/security/p5-openxpki-i18n/distinfo
  head/security/p5-openxpki-i18n/pkg-descr
  head/security/p5-openxpki-i18n/pkg-plist