Bug 191462
| Summary: | [opensolaris] cpu_core should be marked in opensolaris export_syms | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | me.freebsd <me.freebsd> | ||||
| Component: | kern | Assignee: | Mark Johnston <markj> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | emaste, markj, rpaulo | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | CURRENT | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
rpaulo, is this of interest? A commit references this bug: Author: markj Date: Sat Apr 20 11:34:54 UTC 2019 New revision: 346440 URL: https://svnweb.freebsd.org/changeset/base/346440 Log: Export cpu_core from opensolaris.ko. It is referenced by dtrace*.ko. PR: 191462 Submitted by: me.freebsd@cgf.cx MFC after: 1 week Changes: head/sys/modules/opensolaris/Makefile A commit references this bug: Author: markj Date: Sat Apr 27 05:35:20 UTC 2019 New revision: 346785 URL: https://svnweb.freebsd.org/changeset/base/346785 Log: MFC r346440: Export cpu_core from opensolaris.ko. PR: 191462 Changes: _U stable/12/ stable/12/sys/modules/opensolaris/Makefile A commit references this bug: Author: markj Date: Sat Apr 27 05:35:52 UTC 2019 New revision: 346786 URL: https://svnweb.freebsd.org/changeset/base/346786 Log: MFC r346440: Export cpu_core from opensolaris.ko. PR: 191462 Changes: _U stable/11/ stable/11/sys/modules/opensolaris/Makefile |
Created attachment 144224 [details] opensolaris Makefile patch The opensolaris module contains a global "cpu_core" that is used in dtrace. IMO, this means that it should be marked as exported. We found because dtrace would not load after stripping the unstripped opensolaris.ko module which yielded this: link_elf_obj (2): 1 symbol cpu_core undefined linker_load_file: Unsupported file type KLD dtraceall.ko: depends on dtrace - not available or version mismatch So, I propose the attached simple patch to rectify this issue.