Bug 191637

Summary: devel/py-setuptools: Fix bytecompiled files
Product: Ports & Packages Reporter: Melvyn Sopacua <m.r.sopacua>
Component: Individual Port(s)Assignee: Kubilay Kocak <koobs>
Status: Closed FIXED    
Severity: Affects Many People CC: koobs
Priority: Normal Keywords: needs-qa, patch, patch-ready
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
fix-py-setuptools-namespace-packages.patch
none
Fix namespace installation none

Description Melvyn Sopacua 2014-07-05 17:04:22 UTC 
Created attachment 144430 [details]
fix-py-setuptools-namespace-packages.patch

Fixes files that are added to PLIST when using DISTUTILS_AUTOPLIST and the
package is a namespace_package.

Details and upstream PR:
<https://bitbucket.org/pypa/setuptools/pull-request/72/fix-exclude-list-on-python-32/diff>

Note: the port mentioned in the PR needs a oneliner fix to begin with.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-07-05 23:30:53 UTC 
Over to maintainers.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2014-07-06 22:08:23 UTC 
Taking this, I have the update to setuptools (5.3) in flight. Upstream now has 5.4
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2014-07-16 08:50:16 UTC 
Melvyn, py-setuptools 5.4.1 has landed, please:

- Test this issue against the latest revision to reproduce
- Rebase your changes against the latest revision if still reproducible
- Add a comment on upstream PR that it's observable with the 5.4.1

Bonus:

- Produce a failing unit test for the issue that your code fixes, add to the PR
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2014-07-16 08:50:56 UTC 
Removing dependency since setuptools 5.4.1 has been committed and I can't resolve the issue otherwise.
Comment 5 Melvyn Sopacua 2014-07-20 18:12:12 UTC 
The problem still exists, but the logic was moved somewhere else. Investigating...
Comment 6 Melvyn Sopacua 2014-07-20 19:41:02 UTC 
Created attachment 144823 [details]
Fix namespace installation

Was looking at the wrong file. There are minor changes and patch is still needed.
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-01-19 13:26:03 UTC 
A commit references this bug:

Author: koobs
Date: Mon Jan 19 13:25:05 UTC 2015
New revision: 377419
URL: https://svnweb.freebsd.org/changeset/ports/377419

Log:
  devel/py-setuptools: Backport fix for namespace_packages

  Backport an upstream commit [1] that fixes namespace_packages
  for python 3.2+

  While I'm here, update TEST_DEPENDS comment and regression-test
  invocation.

  [1] https://bitbucket.org/pypa/setuptools/pull-request/72

  PR:		191637
  Submitted by:	Melvyn Sopacua <melvyn magemana nl>
  Approved by:	python@

Changes:
  head/devel/py-setuptools/Makefile
  head/devel/py-setuptools/files/patch-setuptools_command_install_lib.py
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2015-01-19 13:27:01 UTC 
Committed, thank you Melvyn! :)