Bug 191727

Summary: [ staging ] emulators/tpm-emulator
Product: Ports & Packages Reporter: Dan Lukes <dan>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Many People CC: marino, wg
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Dan Lukes 2014-07-08 01:54:42 UTC
emulators/tpm-emulator require staging or will be removed

Fix:
Patch is attached. 

--- emulators/tpm-emulator/Makefile.orig	2014-07-08 03:08:32.000000000 +0200
+++ emulators/tpm-emulator/Makefile	2014-07-08 03:49:59.000000000 +0200
@@ -27,7 +27,6 @@
 GROUPS=		_tss
 SUB_LIST=	USERS="${USERS}" GROUPS="${GROUPS}"
 
-NO_STAGE=	yes
 .include <bsd.port.pre.mk>
 
 .if ${ARCH} == "powerpc"
@@ -35,13 +34,10 @@
 .endif
 
 post-install:
-	@${INSTALL} -d -o ${USERS} -g ${GROUPS} -m 0700 ${PREFIX}/var/db/tpm
-	@${INSTALL} -d -o ${USERS} -g ${GROUPS} -m 0700          /var/run/tpm
-
-add-plist-post:
-	@(${ECHO_CMD} "@cwd /"; \
-	  ${ECHO_CMD} "@unexec ${RMDIR} var/run/tpm 2>/dev/null || true"; \
-	  ${ECHO_CMD} "@exec ${INSTALL} -d -o ${USERS} -g ${GROUPS} -m 0700 var/run/tpm"; \
-	 ) >> ${TMPPLIST}
+	@${ECHO_CMD} "@exec ${INSTALL} -d -o ${USERS} -g ${GROUPS} -m 0700 /var/run/tpm" >> ${TMPPLIST}
+	@${MKDIR} ${STAGEDIR}/var/run/tpm
+	@${ECHO_CMD} "@dirrmtry /var/run/tpm" >> ${TMPPLIST}
+	@${ECHO_CMD} "@exec ${INSTALL} -d -o ${USERS} -g ${GROUPS} -m 0700 %D/var/db/tpm" >> ${TMPPLIST}
+	@${MKDIR} ${STAGEDIR}/${PREFIX}/var/db/tpm
 
 .include <bsd.port.post.mk>
Comment 1 William Grzybowski freebsd_committer freebsd_triage 2014-07-08 17:58:38 UTC
Can you please attach the patch as a file?
Comment 2 Dan Lukes 2014-07-08 18:39:44 UTC
I attached them to the report using '-a' option of send-pr - the system utility dedicated to submit the PR. I saved no copy of file attached so I can't attach it once more. In advance and unfortunately, It's hard to use graphics UI for me.

Unless you can use the patch embedded into the report close this PR. Someone else need to save the port. Sorry for wasting your time.
Comment 3 John Marino freebsd_committer freebsd_triage 2014-07-26 07:38:29 UTC
I am not sure "send-pr" tool still has this status.  Or maybe it's been fixed for bugzilla and you are using an obsolete version for gnats.  In any case, committers *really* want attachments, not patches in comments.
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-07-27 13:28:56 UTC
A commit references this bug:

Author: marino
Date: Sun Jul 27 13:28:01 UTC 2014
New revision: 363061
URL: http://svnweb.freebsd.org/changeset/ports/363061

Log:
  stage emulators/tpm-emulator

  While here, simplify powerpc breakage, remove reference to BERLIOS

  PR:		191727
  Submitted by:	Dan Lukes

Changes:
  head/emulators/tpm-emulator/Makefile
Comment 5 John Marino freebsd_committer freebsd_triage 2014-07-27 13:29:49 UTC
Thanks!