Bug 191839
| Summary: | [PATCH] www/boa: Add staging support | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jonathan Price <freebsd> | ||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | marino, rakuco, riggs | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Could you send a version with proper line endings and tabs? Created attachment 144622 [details]
Updated makefile diff with corrected tabs and encoding; sorry.
====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: man/man8/boa.8.gz Additionally, doesn't it make sense to use the @sample keyword for the sample file in the plist? Jonathan, Are you planning to provide a new patch to address these 2 issues Raphael outlined? Apologies for the slow response. I have re-applied my modifications to the latest version of the port, and have updated the pkg-plist. I have attached the diffs for both. However, I am still receiving the following output from a check-plist. I have checked the contents of the STAGEDIR, and the files are in fact there, so I am unsure why check-plist is producing errors: ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: info/boa.info Error: Missing: %%DOCSDIR%%/boa.html Error: Missing: %%DOCSDIR%%/boa.texi Error: Missing: %%DOCSDIR%%/boa.txt Error: Missing: %%DOCSDIR%%/boa_banner.png Created attachment 145069 [details]
Updated makefile diff
Created attachment 145070 [details]
pkg-plist diff
sorry, I didn't read carefully enough, it's not patch-ready. Jonathan says these patches don't result in a good build and needs help figuring out how to finish them. Back to "discussion" A commit references this bug: Author: riggs Date: Sun Aug 10 16:32:45 UTC 2014 New revision: 364550 URL: http://svnweb.freebsd.org/changeset/ports/364550 Log: - Stagify - Add LICENSE - Makefile cleanup - Move pkg-plist into Makefile PLIST var - Add pkg-message.in regarding startup script - Pet portlint PR: 191839 Submitted by: freebsd@jonathanprice.org Approved by: mentors (implicit) Changes: head/www/boa/Makefile head/www/boa/files/pkg-message.in head/www/boa/pkg-plist Most of the plist stuff in this port can be handled by the build framework. I have modified your patch slightly and committed it. Thanks! |
Created attachment 144614 [details] diff of Makefile Patch provides staging support to www/boa.