Bug 191855

Summary: [maintainer update] print/qpdf update to 5.1.2
Product: Ports & Packages Reporter: d.y.kazarov
Component: Individual Port(s)Assignee: Bartek Rutkowski <robak>
Status: Closed FIXED    
Severity: Affects Many People CC: rakuco, robak
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to upgrade port to 5.1.2 none

Description d.y.kazarov 2014-07-13 17:55:09 UTC
Attached patch updates qpdf port to version 5.1.2
Comment 1 d.y.kazarov 2014-07-13 17:56:00 UTC
Created attachment 144638 [details]
Patch to upgrade port to 5.1.2
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2014-07-13 20:57:42 UTC
Please check portlint -- the OPTIONS variables you've added need to appear _after_ {BUILD,LIB}_DEPENDS. And since you don't access ${PORT_OPTIONS}, there is no need to include <bsd.port.options.mk>. Last but not least, you have to remove PORTREVISION.
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-07-26 15:23:21 UTC
A commit references this bug:

Author: robak
Date: Sat Jul 26 15:23:03 UTC 2014
New revision: 362974
URL: http://svnweb.freebsd.org/changeset/ports/362974

Log:
  print/qpdf: update 5.1.1 -> 5.1.2

  - Fix DEPENDS ordering
  - Remove PORTREVISION
  - Remove bsd.port.options.mk
  - Pet portlint

  PR:		191855
  Submitted by:	Dmitry Kazarov <d.y.kazarov@mail.ru>
  Approved by:	swills (mentor)

Changes:
  head/print/qpdf/Makefile
  head/print/qpdf/distinfo
  head/print/qpdf/pkg-plist
Comment 4 Bartek Rutkowski freebsd_committer freebsd_triage 2014-07-26 15:24:11 UTC
Committed, with fixes you can see in commit msg and in the port itself. Thanks for the patch!