Bug 191902

Summary: [update] net-mgmt/tcptrack doesn't build and when patched, segfaults
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed Overcome By Events    
Severity: Affects Some People CC: pi, pkubaj, squat
Priority: Normal Keywords: regression
Version: Latest   
Hardware: amd64   
OS: Any   
Attachments:
Description Flags
This patch enables tcptrack to build
none
patch to update, stage, fix build none

Description Piotr Kubaj freebsd_committer freebsd_triage 2014-07-16 18:06:21 UTC
Created attachment 144731 [details]
This patch enables tcptrack to build

The src/util.cc file misses string.h inclusion. Including it fixes the build. Still, tcptrack segfaults after right after launching.
uname -a: 
FreeBSD DESKTOP1 10.0-RELEASE-p7 FreeBSD 10.0-RELEASE-p7 #12 r268435: Wed Jul  9 00:06:47 CEST 2014     toor@DESKTOP1:/usr/obj/usr/src/sys/DESKTOP1  amd64

make.conf: 
CPUTYPE?=bdver2
WITH_NEW_XORG="YES"
DISTDIR=/tmp
WITH_MSWINDOWS_LICENSE="YES"
TEX_DEFAULT=texlive
WITH_SSP_PORTS=yes
WITH_BDB_VER=6
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2014-07-18 08:01:19 UTC
Tested, several issues:

- distfile is stale, newer (1.4.2) can be found from 
http://pkgs.fedoraproject.org/repo/pkgs/tcptrack/tcptrack-1.4.2.tar.gz/dacf71a6b5310caf1203a2171b598610/

- That one does not build, either
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2014-07-18 08:29:22 UTC
Created attachment 144772 [details]
patch to update, stage, fix build

This patch fixes all build issues. TODO: binary still segfaults 8-(
Comment 3 Baptiste Daroussin freebsd_committer freebsd_triage 2014-08-25 10:16:48 UTC
maintainer has been reset assign to pi@ in the meantime given he is working on it.
if the submitter do want maintainership the port is available now :)
Comment 4 Piotr Kubaj freebsd_committer freebsd_triage 2014-08-25 10:25:44 UTC
(In reply to Baptiste Daroussin from comment #3)
> maintainer has been reset assign to pi@ in the meantime given he is working
> on it.
> if the submitter do want maintainership the port is available now :)

I don't think it's a good idea. Although I can fix simple programming errors, I'm a sysadmin, not a programmer. And since this port touches kernel (networking etc.) I don't think I would manage with maintaining it.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-08-25 10:54:09 UTC
A commit references this bug:

Author: pi
Date: Mon Aug 25 10:53:16 UTC 2014
New revision: 366055
URL: http://svnweb.freebsd.org/changeset/ports/366055

Log:
  net-mgmt/tcptrack: 1.3.0 -> 1.4.2

  - While here, fix build and add staging
  - TODO: binary still segfaults

  PR:		191902
  Submitted by:	pkubaj@riseup.net

Changes:
  head/net-mgmt/tcptrack/Makefile
  head/net-mgmt/tcptrack/distinfo
  head/net-mgmt/tcptrack/files/
  head/net-mgmt/tcptrack/files/patch-IPv6Address.cc
  head/net-mgmt/tcptrack/files/patch-headers.h
  head/net-mgmt/tcptrack/files/patch-util.cc
  head/net-mgmt/tcptrack/pkg-plist
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2014-08-25 11:08:44 UTC
open: Finding the cause of the segfaults.
Comment 7 John Marino freebsd_committer freebsd_triage 2014-08-31 10:33:28 UTC
Removed "stage" from title.  It's already staged and we don't want it showing in a search for PRs of unstaged ports.
Comment 8 Kurt Jaeger freebsd_committer freebsd_triage 2015-03-23 20:50:10 UTC
fixed by commit r382040 from mi@