Bug 191915

Summary: [maintainer] update port: net/opennx
Product: Ports & Packages Reporter: Timothy Beyer <beyert>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: beyert, marino
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
opennx.diff
none
output of port test none

Description Timothy Beyer 2014-07-17 07:56:03 UTC
Created attachment 144744 [details]
opennx.diff

- update to version 0.16.0.729

- mark as LEGAL_PACKAGE, since the NO_PACKAGE macro in this case has nothing to do with legality

- NLS uses gettext

How-To-Repeat:
Apply patch and build port

Fix:
The included patch
Comment 1 Timothy Beyer 2014-07-17 08:02:05 UTC
RedPorts status:

net/opennx 0.16.0.729
10.0-RELEASE/amd64	success	2 minutes	 Buildlog
10.0-RELEASE/i386	success	3 minutes	 Buildlog
9.2-RELEASE/amd64	success	2 minutes	 Buildlog
9.2-RELEASE/i386	success	3 minutes	 Buildlog
QATty	success	3 minutes	 Buildlog

Note that I had to remove the NO_PACKAGE macro from the script to get RedPorts to say anything other than "dud", which is inaccurate..

The actual submission has the NO_PACKAGE and LEGAL_PACKAGE macros, as it should.
Comment 2 Timothy Beyer 2014-07-17 08:02:28 UTC
RedPorts status:

net/opennx 0.16.0.729
10.0-RELEASE/amd64	success	2 minutes	 Buildlog
10.0-RELEASE/i386	success	3 minutes	 Buildlog
9.2-RELEASE/amd64	success	2 minutes	 Buildlog
9.2-RELEASE/i386	success	3 minutes	 Buildlog
QATty	success	3 minutes	 Buildlog

Note that I had to remove the NO_PACKAGE macro from the script to get RedPorts to say anything other than "dud", which is inaccurate..

The actual submission has the NO_PACKAGE and LEGAL_PACKAGE macros, as it should.

https://redports.org/buildarchive/20140717073300-21737/
Comment 3 Timothy Beyer 2014-07-17 08:05:39 UTC
Created attachment 144745 [details]
output of port test

- output of "port test" included
Comment 4 Timothy Beyer 2014-07-17 08:19:08 UTC
output of portlint -CA:

<verbatim>WARN: Makefile: "NO_PACKAGE" found. do not forget to update ports/LEGAL.
0 fatal errors and 1 warning found.</verbatim>

Note that I believe it only gives the warning because I suspect that portlint has not yet been updated to recognize the LEGAL_PACKAGE macro yet..
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-07-27 00:58:36 UTC
A commit references this bug:

Author: marino
Date: Sun Jul 27 00:57:35 UTC 2014
New revision: 363004
URL: http://svnweb.freebsd.org/changeset/ports/363004

Log:
  net/opennx: Update version 0.16.0.725 => 0.16.0.729

  PR:		191915
  Submitted by:	maintainer (Timothy Beyer)

Changes:
  head/net/opennx/Makefile
  head/net/opennx/distinfo
Comment 6 John Marino freebsd_committer freebsd_triage 2014-07-27 00:59:22 UTC
Thanks!