Summary: | [PATCH] databases/rrdtool: strip(1) the RRDs.so | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | takefu | ||||
Component: | Individual Port(s) | Assignee: | Niclas Zeising <zeising> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | marino | ||||
Priority: | Normal | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
over to maintainer As far as I can tell, that patch doesn't run strip at all. maybe the addition of "-s" is what strips it...? I did not see that. What's up with the other changes though? Also, this will strip even if DEBUG is set. How to reproduce. Write to/etc/make.conf 'DEVELOPER = yes' to run make -dl > echo "====> Running Q/A tests (stage-qa)" > ====> Running Q/A tests (stage-qa) > /usr/bin/env STAGEDIR=/usr/ports/databases/rrdtool/work/stage PREFIX=/usr/local LOCALBASE=/usr/local "STRIP=-s" USESLIBTOOL=yes /bin/sh /usr/ports/Mk/Scripts/qa.sh > Warning: 'lib/perl5/site_perl/5.20/mach/auto/RRDs/RRDs.so' is not stripped consider using ${STRIP_CMD} Is used for patch of my warning will disappear. (In reply to Niclas Zeising from comment #4) > I did not see that. What's up with the other changes though? > Also, this will strip even if DEBUG is set. A commit references this bug: Author: zeising Date: Sat Aug 30 18:55:24 UTC 2014 New revision: 366667 URL: http://svnweb.freebsd.org/changeset/ports/366667 Log: Strip RRDs.so Approach choosen is different from the one in the PR. PR: 192077 Submitted by: takefu@airport.fm Changes: head/databases/rrdtool/Makefile Fixed, using a different approach. Thanks for the submission! |
Created attachment 144924 [details] rrdtool.patch strip(1) the RRDs.so