Summary: | [patch] net-p2p/transmission-gtk fails to build after update security/openssl | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Ivan Klymenko <fidaj> | ||||||
Component: | Individual Port(s) | Assignee: | Chris Rees <crees> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | cjpm, marino | ||||||
Priority: | --- | ||||||||
Version: | Latest | ||||||||
Hardware: | amd64 | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Ivan Klymenko
2014-08-01 21:39:54 UTC
Over to maintainer I'm getting this too on DF, it needs -lcrypto in LDFLAGS I think (In reply to John Marino from comment #2) > I'm getting this too on DF, it needs -lcrypto in LDFLAGS I think You're right - your solution eliminates this problem. In addition, I found that the option <--enable-inotify> is not valid as a result of such changes are necessary here --- Makefile.orig 2014-08-03 11:30:44.000000000 +0300 +++ Makefile 2014-08-03 12:35:53.000000000 +0300 @@ -20,11 +20,12 @@ USE_GNOME= gtk30 intlhack USES= gettext pathfix desktop-file-utils INSTALLS_ICONS= yes +LDFLAGS+= -lcrypto -linotify EXTRA_CONF_ARGS=--disable-cli \ --disable-daemon \ --with-gtk \ - --enable-inotify \ + --with-inotify \ --disable-mac \ --enable-nls Thanks Ivan. I'll confirm and then commit it under the "just fix it" blanket. Created attachment 145293 [details]
Makefile fix patch
this isn't the correct solution. transmission-gtk is a slave port and this doesn't fix the other slaves (or master). And it might be conditional if lssl isn't always compiled in. A commit references this bug: Author: marino Date: Sun Aug 3 16:06:59 UTC 2014 New revision: 363920 URL: http://svnweb.freebsd.org/changeset/ports/363920 Log: Fix transmission-cli,-gtk on some platforms after openssl update At least on some releases, transmission-cli and transmission-gtk now need -lcypto in LDFLAGS to build. Additionally transmission-gtk needed an update of the inotify configure argument. The latter requires a revbump because it seems possible that it could have been built with the bad argument somewhere. PR: 192319 Submitted by: Ivan Klymenko Approved by: "Just Fix It" blanket, but maintainer was in copy on PR Changes: head/net-p2p/transmission-cli/Makefile head/net-p2p/transmission-gtk/Makefile Should be fixed now. (In reply to John Marino from comment #8) > Should be fixed now. Thanks. but I have 2 more suspected - As necessary to remove from net-p2p/transmission-qt4/Makefile the string <LDFLAGS+= -lcrypto> because it is already in net-p2p/transmission-cli/Makefile - You probably forgot to add to the client port -linotify, because make -C /usr/ports/net-p2p/transmission-gtk configure error: ... checking for posix_fadvise... yes checking sys/inotify.h usability... yes checking sys/inotify.h presence... yes checking for sys/inotify.h... yes checking for inotify_init... no configure: error: "inotify not found!" ===> Script "configure" failed unexpectedly. Please report the problem to crees@FreeBSD.org [maintainer] and attach the "/media/da0s1/obj/usr/ports/net-p2p/transmission-gtk/work/transmission-2.84/config.log" including the output of the failure of your make command. Also, it might be a good idea to provide an overview of all packages installed on your system (e.g. a /usr/local/sbin/pkg-static info -g -Ea). *** Error code 1 Stop. make[1]: stopped in /usr/ports/net-p2p/transmission-gtk *** Error code 1 Stop. make: stopped in /usr/ports/net-p2p/transmission-gtk (In reply to Ivan Klymenko from comment #9) > but I have 2 more suspected > - As necessary to remove from net-p2p/transmission-qt4/Makefile the string > <LDFLAGS+= -lcrypto> because it is already in > net-p2p/transmission-cli/Makefile Okay, thanks. > - You probably forgot to add to the client port -linotify, because make -C > /usr/ports/net-p2p/transmission-gtk configure error: I did, thanks for the reminder. (In reply to John Marino from comment #10) > (In reply to Ivan Klymenko from comment #9) > > but I have 2 more suspected > > - As necessary to remove from net-p2p/transmission-qt4/Makefile the string > > <LDFLAGS+= -lcrypto> because it is already in > > net-p2p/transmission-cli/Makefile > > Okay, thanks. > > > > - You probably forgot to add to the client port -linotify, because make -C > > /usr/ports/net-p2p/transmission-gtk configure error: > > I did, thanks for the reminder. Thanks. A commit references this bug: Author: marino Date: Sun Aug 3 18:05:29 UTC 2014 New revision: 363928 URL: http://svnweb.freebsd.org/changeset/ports/363928 Log: transmission-* cleanup I missed the -linotify LDFLAG on the transmission-gtk port. It was also pointed out by the submitter than transmission-qt4 now has a duplicate -lcrypto LDFLAG so let's remove that. PR: 192319 Submitted by: Ivan Klymenko Changes: head/net-p2p/transmission-gtk/Makefile head/net-p2p/transmission-qt4/Makefile Created attachment 145323 [details]
patch.diff
- net-p2p/transmission-gtk depends on devel/libinotify
A commit references this bug: Author: marino Date: Mon Aug 4 06:19:37 UTC 2014 New revision: 363966 URL: http://svnweb.freebsd.org/changeset/ports/363966 Log: net-p2p/transmission-gtk: complete the -inotify fix with LIB_DEPENDS+= In a previous commit, the inotify configuration was fixed, but we neglected to guarantee the library was available. This adds libinotify to the LIB_DEPENDS list, an action that requires a revbump. PR: 192319 Suggested by: Carlos JPM Changes: head/net-p2p/transmission-gtk/Makefile |