Bug 192367

Summary: [NEW PORT] finance/bitcoin-armory
Product: Ports & Packages Reporter: Yuri Victorovich <yuri>
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Only Me CC: riggs
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch
none
updated patch
none
poudriere build log
none
updated patch: added ONLY_FOR_ARCHS
none
Corrected the submitter full name only none

Description Yuri Victorovich freebsd_committer freebsd_triage 2014-08-04 00:44:19 UTC 
Please check in this port for those using bitcoins.

Please note that it currently prints these harmless error messages during runtime:
(ERROR) announcefetch.py:267 - Tried: https://bitcoinarmory.com/announce.txt?osvar=freebsd&os=bsd&ver=0.92.1&id=719b90dd
(ERROR) announcefetch.py:162 - Loop was busy for more than one second

This is maybe because this site doesn't recognize our OS name.

BitcoinArmory currently doesn't build with clang. clang finds some invalid assembly expanded from some macros. I will let developers know and hopefully they will fix the problem. For now I left USE_GCC=yes.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2014-08-04 00:47:30 UTC 
Created attachment 145325 [details]
patch
Comment 2 John Marino freebsd_committer freebsd_triage 2014-08-04 08:27:54 UTC 
Thanks!  Do you have any verification available?  In order of preference, examples of what I'm looking for are:

1) "poudriere testport" or "poudriere bulk -t" logs
2) Redports or tinderbox logs
3) "make check-plist" followed by "make stage-qa" output
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2014-08-04 19:34:30 UTC 
I am running "poudriere testport". However, poudriere html logs feature seems to be broken (https://github.com/bdrewery/poudriere/issues/12).
So which log file(s) should I attach then?
Comment 4 John Marino freebsd_committer freebsd_triage 2014-08-04 19:40:48 UTC 
if it's a local installation of poudriere, just go to the data directory, logs, and you'll find the log.

Either latest, latest-per-pkg, etc.  It's on your drive, you don't need a web browser to find it.

also, I don't think that error prevents you from right-click save the log from the web interface either.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2014-08-05 07:21:52 UTC 
Created attachment 145381 [details]
updated patch
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2014-08-05 07:25:00 UTC 
Created attachment 145384 [details]
poudriere build log
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2014-08-05 07:26:28 UTC 
I have attached the updated patch and the build log.
Package builds without any problems.
Comment 8 John Marino freebsd_committer freebsd_triage 2014-08-05 07:33:04 UTC 
okay, but next time don't compress the log, otherwise I can't see it in the browser.
Comment 9 John Marino freebsd_committer freebsd_triage 2014-08-05 07:34:25 UTC 
yuri: thanks

For the committer that picks this up, it's patch ready:

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for directories owned by MTREEs
===> Checking for directories handled by dependencies
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
====>> Checking for staging violations... done
Comment 10 Yuri Victorovich freebsd_committer freebsd_triage 2014-08-06 09:09:38 UTC 
Created attachment 145413 [details]
updated patch: added ONLY_FOR_ARCHS
Comment 11 Yuri Victorovich freebsd_committer freebsd_triage 2014-08-23 18:37:34 UTC 
Created attachment 146185 [details]
Corrected the submitter full name only
Comment 12 commit-hook freebsd_committer freebsd_triage 2014-08-23 20:17:47 UTC 
A commit references this bug:

Author: riggs
Date: Sat Aug 23 20:17:19 UTC 2014
New revision: 365805
URL: http://svnweb.freebsd.org/changeset/ports/365805

Log:
  - Import bitcoin-armory into finance,
    an implementation of desktop bitcoin management system
  - Assign maintainership to port submitter Yuri Victorovich <yuri@rawbw.com>

  PR:		192367
  Submitted by:	Yuri Victorovich <yuri@rawbw.com>
  Approved by:	mentors (implicit)

Changes:
  head/finance/Makefile
  head/finance/bitcoin-armory/
  head/finance/bitcoin-armory/Makefile
  head/finance/bitcoin-armory/distinfo
  head/finance/bitcoin-armory/files/
  head/finance/bitcoin-armory/files/patch-ArmoryQt.py
  head/finance/bitcoin-armory/files/patch-ArmoryUtils.py
  head/finance/bitcoin-armory/files/patch-Makefile
  head/finance/bitcoin-armory/files/patch-announcefetch.py
  head/finance/bitcoin-armory/files/patch-cppForSwig-Makefile
  head/finance/bitcoin-armory/files/patch-cppForSwig-cryptopp-Makefile
  head/finance/bitcoin-armory/files/patch-dpkgfiles-armory
  head/finance/bitcoin-armory/pkg-descr
  head/finance/bitcoin-armory/pkg-message
  head/finance/bitcoin-armory/pkg-plist
Comment 13 Thomas Zander freebsd_committer freebsd_triage 2014-08-23 20:21:16 UTC 
Committed with minor polishing. Thanks!