Bug 192385
| Summary: | [PATCH] graphics/cimg: DIST_SUBDIR dependent on version (and PORTREVISION) | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dmitry Marakasov <amdmi3> |
| Component: | Individual Port(s) | Assignee: | Thierry Thomas <thierry> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
ASSIGN to maintainer This is on purpose: unfortunately, this port's tarball is often rerolled after a release without bumping the version number. In this case, I bump the PORTREVISION and update the port with the new tarball.
Of course, there is a problem when PORTREVISION is bumped for a different reason.
I'm going to think about something like:
DIST_SUBDIR= ${PORTNAME}-${PORTVERSION}_${TARBALLREVISION}
Fixed. Thanks for the reminder! A commit references this bug: Author: thierry Date: Fri Aug 15 12:28:06 UTC 2014 New revision: 364967 URL: http://svnweb.freebsd.org/changeset/ports/364967 Log: Don't force to fetch again the tarball after a PORTREVISION's bump. PR: ports/192385 Submitted by: amdmi3 Changes: head/graphics/cimg/Makefile |
cimg has DIST_SUBDIR= ${PORTNAME}-${PORTVERSION}_${PORTREVISION} Is there reason for subdir in if there is than is there a reason for subdir to contain port version, especially revision? The latter is the worst as it forces users to redownload distfile with every portrevsion change. It's also error prone (committers do not expect to update distinfo after PORTREVISION bump) - I've just fixed such error. I suggest to demove DIST_SUBDIR or atlest to strip it to ${PORTNAME} Port maintainer (thierry@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 1.02 (mode: change, diff: SVN)