Bug 192489

Summary: "Raw Unified" link on attachments goes to FreeBSD support page instead
Product: Services Reporter: Warren Block <wblock>
Component: Bug TrackerAssignee: Bugmeister <bugmeister>
Status: Closed FIXED    
Severity: Affects Some People CC: clusteradm, koobs, peter, rdivacky
Priority: ---    
Version: unspecified   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192916

Description Warren Block freebsd_committer freebsd_triage 2014-08-07 20:26:19 UTC
View https://bugs.freebsd.org/bugzilla/attachment.cgi?id=145426&action=diff

Click the Raw Unified link at the upper left.  Rather than showing a raw unified diff, it goes to https://www.freebsd.org/support.html .
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2014-08-27 09:41:48 UTC
Confirming issue is still present.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2014-08-27 09:56:22 UTC
The issue is related to the Request:

"http://bz-attachments.freebsd.org/attachment.cgi?id=146350&action=diff&collapsed=&context=patch&format=raw&headers=1"

Which then returns the following Response:

Location:"//www.freebsd.org/support.html"

bz-attachments.freebsd.org also returns the same 302.

This may be a web server, varnish or virtualhost configuration issue, CC'ing clusteradm@
Comment 3 Peter Wemm freebsd_committer freebsd_triage 2014-09-13 04:02:44 UTC
This should be fixed as of about two weeks ago.. could you check and close please? 

From the front end server:
------------------------------------------------------------------------
r6291 | peter | 2014-08-29 12:35:49 -0700 (Fri, 29 Aug 2014) | 3 lines

Stop trying to be smart. Don't interfere with attachment.cgi with params.
------------------------------------------------------------------------


...
 	} elsif (req.http.host == "bz-attachments.freebsd.org") {
-		if (req.url ~ "^/attachment\.cgi\?id=([0-9]+)$") {
+		if (req.url ~ "^/attachment\.cgi") {
...
Comment 4 Warren Block freebsd_committer freebsd_triage 2014-09-13 04:37:18 UTC
Looks fixed to me.  Both the View and Raw Unified links go to the same place, a raw diff.  I don't know if View used to go to something else, but the Raw Unified link works.
Comment 5 Marcus von Appen freebsd_committer freebsd_triage 2014-09-20 07:43:01 UTC
The issue is fixed, a misbehaviour could not be detected anymore.