Bug 192507
| Summary: | [PATCH] databases/pgbouncer fix install without DOCS option | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | dmitry2004 | ||||||
| Component: | Individual Port(s) | Assignee: | John Marino <marino> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | CC: | m.tsatsenko, swills | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
The pkg-plist is correct. Man pages are always installed. They should not be controlled by DOCS option. If they are, that is a mistake. man pages are not considered "DOCS". Moveover, even if this wasn't the case, your page is wrong. That's pre-stage notation. Please acknowledge so I can close PR, it's invalid. Hmm, i just looked at the current state of the port, it's doing exactly what I said it shouldn't be doing. I'll fix the port. let's CC the maintainer so he knows what's going on. this port also features <options>, <pre> and <post>, so there's an 80%+ chance that this is wrong. okay, I think what's going on is the man pages need to be generated which requires the xmlto dependency. The maintainer is trying to give the user the option not to build the man pages but this isn't conventional. AFAICT, the DOCS option is limited only to manpages and not really docs. In reality, we don't need any options at all on this port. Created attachment 145524 [details]
Remove docs option from pgbouncer
In my opinion, this is how pgbouncer should be modified. The DOCS option is removed, manpages are always built.
It looks like m.tsatsenko did this intentionally in bug 189787 so we need to wait and hear what he has to say. Steve Wills put it through, so maybe the logic is that xmlto is too heavy not to have an option to disable it, but we're always supposed to install man pages. I would like to have the ability to disable extra dependency. (In reply to dmitry2004 from comment #8) > I would like to have the ability to disable extra dependency. If it's against policy, it's generally not going to happen (e.g. your desire doesn't play a part in the desire). Maybe this particular case has been given a waiver, that's what I'm waiting to hear. Nothing stops m.tsatsenko from pregenerating the man pages and providing them via ${FILESDIR} or a second download, so there are ways to avoid it if he really wants to. (In reply to John Marino from comment #9) > If it's against policy, it's generally not going to happen (e.g. your desire > doesn't play a part in the *desire). Maybe this particular case has been *decision (In reply to John Marino from comment #9) > pregenerating the man pages and providing them via ${FILESDIR} That sounds good A commit references this bug: Author: marino Date: Sun Aug 10 21:42:51 UTC 2014 New revision: 364574 URL: http://svnweb.freebsd.org/changeset/ports/364574 Log: databases/pgbouncer: Unconditionally install man pages This port had a couple of issues besided installing man pages as a function of the DOCS option selection. It also was using <pre> and <post> inclusions with <options>, _DEPENDS were in multiple places. I regrouped the *_DEPENDS, I moved the options to just above the make targets (their conventional location) and I utilized <option>_*_DEPENDS as well after fixing the man pages. PR: 192507 Reported by: dmitry2004 (yandex.ru) Approved by: Just Fix It (maintainer in copy) Changes: head/databases/pgbouncer/Makefile I conferred with swills@ and he agreed the man pages shouldn't be built per option. If the maintainer wants to make xmlto optional, then he could look at options that involve pregenerating the man pages to avoid it. (In reply to John Marino from comment #13) > I conferred with swills@ and he agreed the man pages shouldn't be built per > option. If the maintainer wants to make xmlto optional, then he could look > at options that involve pregenerating the man pages to avoid it. Distrib include pregenerated the man pages, xmlto dependency not need. A commit references this bug: Author: marino Date: Sat Aug 16 20:27:15 UTC 2014 New revision: 365132 URL: http://svnweb.freebsd.org/changeset/ports/365132 Log: databases/pgbouncer: Remove unnecessary dependency xmlto It turns out that xmlto is not needed for documentation at all now. The man pages are pregenerated and provided in the tarball. PR: 192507 Reported by: dmitry2004 (yandex.ru) Changes: head/databases/pgbouncer/Makefile |
Created attachment 145513 [details] Patch In pkg-plist rigidly listed man files, but they do not install witout DOCS option set.