Bug 192516

Summary: DTrace not yet supported on ARM
Product: Base System Reporter: George V. Neville-Neil <gnn>
Component: armAssignee: George V. Neville-Neil <gnn>
Status: Closed FIXED    
Severity: Affects Many People CC: emaste, howard0su, rpaulo
Priority: ---    
Version: CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch from gonzo@ to get DTrace running on ARM
none
Patch from Howard Su none

Description George V. Neville-Neil freebsd_committer freebsd_triage 2014-08-08 16:19:31 UTC
Created attachment 145527 [details]
Patch from gonzo@ to get DTrace running on ARM

DTrace is not currently supported on ARM.  There is a patch, attached, from gonzo@ which gets us started down this road.
Comment 1 Rui Paulo freebsd_committer freebsd_triage 2014-08-09 03:39:12 UTC
Created attachment 145544 [details]
Patch from Howard Su
Comment 2 George V. Neville-Neil freebsd_committer freebsd_triage 2014-08-09 08:49:29 UTC
Thanks Rui.  I've kicked off a build with Howard's patch and will test with that.
Comment 3 George V. Neville-Neil freebsd_committer freebsd_triage 2014-08-09 14:17:15 UTC
I keep getting the following error:

ld -d -warn-common -r -d -o dtrace.kld dtrace.o dtrace_asm.o dtrace_subr.o assym.o opensolaris_taskq.o
ld: ERROR: Source object assym.o has EABI version 0, but target dtrace.kld has EABI version 5
ld: failed to merge target specific data of file assym.o

with the patch from Howard Su.  I will track this down but if anyone has a hint, send it along.
Comment 4 George V. Neville-Neil freebsd_committer freebsd_triage 2014-08-09 21:22:08 UTC
Looks like my loader error was a misapplication of the patch.
Comment 5 George V. Neville-Neil freebsd_committer freebsd_triage 2014-08-10 02:47:47 UTC
I now have a test version of this patch in a my git repo.  I'll apply to svn and then commit to HEAD where others can work on it.
Comment 6 Rui Paulo freebsd_committer freebsd_triage 2014-08-10 19:52:55 UTC
Are you using Howard Su's patch?  He updated it based on gonzo's patch.
Comment 7 Rui Paulo freebsd_committer freebsd_triage 2014-08-10 19:53:36 UTC
(In reply to Rui Paulo from comment #6)
> Are you using Howard Su's patch?  He updated it based on gonzo's patch.

Nevermind.  I just read your comment again...
Comment 8 Rui Paulo freebsd_committer freebsd_triage 2014-08-10 19:54:37 UTC
Do you have any system where you can test this?  Ideally, you'd want both an ARM SMP system and an UP system.
Comment 9 Rui Paulo freebsd_committer freebsd_triage 2014-08-10 19:59:13 UTC
Also, George, can you create a CR with your patch?  I wanted to discuss some parts of the patch before it hits head.  Please add Mark to the CR too (and other ARM guys you think would be interested).
Comment 10 George V. Neville-Neil freebsd_committer freebsd_triage 2014-08-10 20:54:01 UTC
(In reply to Rui Paulo from comment #9)
> Also, George, can you create a CR with your patch?  I wanted to discuss some
> parts of the patch before it hits head.  Please add Mark to the CR too (and
> other ARM guys you think would be interested).

Sorry, what's a CR?  You mean a proposed patch in Phabric?

I'm working up the patch against HEAD in svn now.

Best,
George
Comment 11 Rui Paulo freebsd_committer freebsd_triage 2014-08-10 22:44:59 UTC
Yes, a phabric review.
Comment 12 George V. Neville-Neil freebsd_committer freebsd_triage 2015-06-26 01:24:39 UTC
This has been committed for ARMv7 with work by various folks including Ruslan, Bjoern, Andy, Ed Maste, Robert Watson etc.