Bug 192616
| Summary: | [PATCH] x11/xscreensaver: Fix stage-qa error, fix pkg-plist, cleanup | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jason E. Hale <jhale> | ||||
| Component: | Individual Port(s) | Assignee: | Niclas Zeising <zeising> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | zeising | ||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: zeising Date: Sat Aug 30 18:47:42 UTC 2014 New revision: 366663 URL: http://svnweb.freebsd.org/changeset/ports/366663 Log: - Fix shebangs by defining PERL in CONFIGURE_ENV - Add some missing files to pkg-plist, don't try to remove mtree dirs, and get rid of ugly plist hack from Makefile (it is broken with staging anyways, so add gdkpixbuf2 as dependency to make sure that "bin/xscreensaver-hacks/webcollage-helper" is always installed) - Deal with SETUID_HACK with @mode directive instead of with the configure option so that a regular user can build and then install as root - Move some LIB_DEPENDS to USE_GNOME - Use options helpers - Remove PTHREADS option as there is no longer a configure knob for it - Remove KERBEROS option since it is broken (needs ancient krb4 lib which we don't have anymore) - Simplify post-patch commands. The hacks for the PAM option don't need to be conditional. Staging will handle whether the file is installed or not. - Pet portlint(1) - Bump PORTREVISION PR: 192616 Submitted by: jhale Changes: head/x11/xscreensaver/Makefile head/x11/xscreensaver/pkg-plist Patch comitted, thanks for the submission and apologies for taking so long to get to this. |
Created attachment 145719 [details] xscreensaver fix - Fix shebangs by defining PERL in CONFIGURE_ENV - Add some missing files to pkg-plist, don't try to remove mtree dirs, and get rid of ugly plist hack from Makefile (it is broken with staging anyways, so add gdkpixbuf2 as dependency to make sure that "bin/xscreensaver-hacks/webcollage-helper" is always installed) - Deal with SETUID_HACK with @mode directive instead of with the configure option so that a regular user can build and then install as root - Move some LIB_DEPENDS to USE_GNOME - Use options helpers - Remove PTHREADS option as there is no longer a configure knob for it - Remove KERBEROS option since it is broken (needs ancient krb4 lib which we don't have anymore) - Simplify post-patch commands. The hacks for the PAM option don't need to be conditional. Staging will handle whether the file is installed or not. - Pet portlint(1) - Bump PORTREVISION