Bug 192645

Summary: [patch][sysutils/fusefs-encfs]Include climits on FreeBSD
Product: Ports & Packages Reporter: Olivier - interfaSys sàrl <software-freebsd>
Component: Individual Port(s)Assignee: John Marino <marino>
Status: Closed FIXED    
Severity: Affects Only Me CC: marino
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Added climits
none
patch against the port itself none

Description Olivier - interfaSys sàrl 2014-08-13 22:22:15 UTC
Created attachment 145762 [details]
Added climits

Compilation failed, when using gcc48. The compiler complained about some undefined constants. I traced it back to a missing include.
Attached is a modified patch-encfs__encfsctl.cpp
Comment 1 John Marino freebsd_committer 2014-08-13 23:35:04 UTC
you really have to start providing proper patches.

That means a patch to create files/patch-mypatchname file.

you're just attaching the contents and leaving it to the committer to create the file.  You need to patch the port itself, not the software.
Comment 2 John Marino freebsd_committer 2014-08-16 09:28:42 UTC
In other words, I'm expected another submission.  This PR is in limbo.
Comment 3 Olivier - interfaSys sàrl 2014-08-16 09:34:15 UTC
I will :)
C++ is not my area of expertise, so I was waiting for some feedback on that include, that's all.
Comment 4 John Marino freebsd_committer 2014-08-16 09:38:58 UTC
there's nobody around to give you feedback.  The port is unmaintained.
Comment 5 Olivier - interfaSys sàrl 2014-08-16 09:57:51 UTC
Created attachment 145862 [details]
patch against the port itself

This patch should be ready to apply
Comment 6 John Marino freebsd_committer 2014-08-16 10:02:47 UTC
port has no maintainer, therefore moving to "patch-ready" status.
Comment 7 John Marino freebsd_committer 2014-08-17 19:48:10 UTC
all for nothing, the patch doesn't apply.  I have to generate it myself.
Comment 8 John Marino freebsd_committer 2014-08-17 19:53:29 UTC
interestingly, the offsets of my patch are 4 higher than the original (obsolete) patch that I checked it against.  Other than that, identical.
Comment 9 commit-hook freebsd_committer 2014-08-17 19:57:17 UTC
A commit references this bug:

Author: marino
Date: Sun Aug 17 19:56:16 UTC 2014
New revision: 365237
URL: http://svnweb.freebsd.org/changeset/ports/365237

Log:
  sysutils/encfs: Fix compilation on gcc48

  PR:		192645
  Submitted by:	Olivier (interfaSys)

Changes:
  head/sysutils/fusefs-encfs/files/patch-encfs__encfsctl.cpp
Comment 10 John Marino freebsd_committer 2014-08-17 19:57:49 UTC
the fix is in, thanks.