Bug 192647
| Summary: | [PATCH] sysutils/LPRng 3.8.C updates broke config file locations | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Adam McDougall <ebay> | ||||||
| Component: | Individual Port(s) | Assignee: | John Marino <marino> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | marino | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
no maintainer to move to patch-ready Created attachment 145771 [details]
Revised patch (bump portrevision)
Oops, forgot portrevision bump, uploading new patch.
i already fixed this but commit messages are delayed a while, take so nobody duplicates work. A commit references this bug: Author: marino Date: Thu Aug 14 20:43:49 UTC 2014 New revision: 364866 URL: http://svnweb.freebsd.org/changeset/ports/364866 Log: sysutils/LPRng: previous update broke config file locations, so fix them PR: 192647 Submitted by: Adam McDougall Approved by: Nobody; port is unmaintained Changes: head/sysutils/LPRng/Makefile head/sysutils/LPRng/pkg-plist |
Created attachment 145766 [details] Fix config path regression, improve sample config installation Short version: patch included to fix regression (wrong compiled config path in binaries), and switch port to @sample in plist. I upgraded to the latest lprng 3.8.C port today and found lpq/lpr/(other?) were miscompiled with a broken path: # lpq -Pprinter Read_file_list: cannot stat required or included file '/lpd.conf' - No such file or directory After investigation, I found the following two lines in the Makefile are breaking it. Simply remove them (tested). --with-lpd_conf_path=${SYSCONFDIR}/lpd.conf \ --with-lpd_perms_path=${SYSCONFDIR}/lpd.perms \ Additionally, I saw @sample was not being used in pkg-plist so I decided to try it out as an improvement. Since the paths compiled above expect config files in /usr/local/etc, I thought that seems like a better place for the config files so I switched from DATADIR to PREFIX/etc which saves a few lines here and there. If this part is contentious, I'm happy to leave it out, but the binaries do need to get fixed. Thanks.