Bug 192724

Summary: [patch] devel/gnome-vfs: doesn't completely ignore auto detect of sys/inotify.h
Product: Ports & Packages Reporter: Lawrence Chen <beastie>
Component: Individual Port(s)Assignee: freebsd-gnome (Nobody) <gnome>
Status: Closed FIXED    
Severity: Affects Only Me CC: danilo, grahamperrin, nivit, randy+bsd, sergey.v.brunov
Priority: ---    
Version: Latest   
Hardware: amd64   
OS: Any   
Attachments:
Description Flags
screenshot of shutter failure on FreeBSD-CURRENT
none
gnome-vfs none

Description Lawrence Chen 2014-08-17 01:41:42 UTC 
On:
FreeBSD 9.2-RELEASE-p10 #0: Tue Jul  8 10:48:24 UTC 2014     root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC 

Been stumped by this error:

/usr/local/lib/gnome-vfs-2.0/modules/libfile.so: Undefined symbol "ih_startup"

Eventually found that in post-patch it changes "inotify_support=yes" to "inotify_support=no".  However this is one of two things configure does when it auto-detects sys/inotify.h.

Which allowed me to decide that the application wasn't for me, so I deleted it.

But, here's the patch:

--- patch-config.h.in.orig      2014-01-22 11:40:44.000000000 -0600
+++ patch-config.h.in   2014-08-16 20:20:26.933911743 -0500
@@ -1,6 +1,6 @@
---- config.h.in.orig   Sun May  7 00:54:09 2006
-+++ config.h.in        Sun May  7 00:54:46 2006
-@@ -121,6 +121,9 @@
+--- config.h.in.orig   2010-09-28 04:35:21.000000000 -0500
++++ config.h.in        2014-08-16 20:20:09.534309070 -0500
+@@ -133,6 +133,9 @@
  /* Define to 1 if you have the <fnmatch.h> header file. */
  #undef HAVE_FNMATCH_H
  
@@ -10,3 +10,12 @@
  /* Define to 1 if you have the <fstab.h> header file. */
  #undef HAVE_FSTAB_H
  
+@@ -429,7 +432,7 @@
+ #undef HAVE_SYS_CDIO_H
+ 
+ /* Define to 1 if you have the <sys/inotify.h> header file. */
+-#undef HAVE_SYS_INOTIFY_H
++/* undef HAVE_SYS_INOTIFY_H */
+ 
+ /* Define to 1 if you have the <sys/mntctl.h> header file. */
+ #undef HAVE_SYS_MNTCTL_H
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-17 07:54:46 UTC 
Alright, it would be been better to have the patch as an attachment, but I understand you might not have it anymore since you don't use the software.

Over to maintainer
Comment 2 Sergey Brunov 2015-01-15 14:22:19 UTC 
It seems the issue affects gnome-commander2 port.

The gnome-commander2 fails on start:
/usr/local/lib/gnome-vfs-2.0/modules/libfile.so: Undefined symbol "ih_startup".

It would be great to have the issue fixed.
Comment 3 Graham Perrin freebsd_committer freebsd_triage 2017-04-25 02:56:28 UTC 
With recent versions of TrueOS Desktop (based on FreeBSD-CURRENT), I can no longer use shutter: 

$ shutter
WARNING: Gtk2::AppIndicator is missing --> there will be no icon showing up in the status bar when running Unity!
 
/usr/local/lib/gnome-vfs-2.0/modules/libfile.so: Undefined symbol "ih_startup"
$ 

– I guess, that's this bug 192724. 

----

Not an issue with a boot environment from last month, 

$ beadm list
BE                              Active Mountpoint  Space Created
failsafe                        -      -           17.6G 2017-03-08 02:52
12.0-CURRENT-up-20170330_080908 R      -           46.6G 2017-03-30 08:07
12.0-CURRENT-up-20170421_000145 -      -           12.5G 2017-04-20 23:09
12.0-CURRENT-up-20170421_061720 -      -          219.3M 2017-04-21 06:16
12.0-CURRENT-up-20170421_183905 -      -           12.4G 2017-04-21 17:45
12.0-CURRENT-up-20170425_023422 N      /           12.2G 2017-04-25 01:40
$ shutdown -r now
Comment 4 Graham Perrin freebsd_committer freebsd_triage 2017-04-25 18:12:28 UTC 
Created attachment 182088 [details]
screenshot of shutter failure on FreeBSD-CURRENT

Reproduced with FreeBSD-CURRENT (without TrueOS).
Comment 5 Randy 2017-04-26 15:50:55 UTC 
Would like to confirm that this issue also exists on FreeBSD 11-stable
Comment 6 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2017-10-10 01:57:00 UTC 
Resurrecting the PR... I'm getting this error on 12 CURRENT. It's affecting gnome-commander2.

/usr/local/lib/gnome-vfs-2.0/modules/libfile.so: Undefined symbol "ih_startup"

If I build gnome-vfs with inotify support it just works again.

Index: Makefile
===================================================================
--- Makefile	(revision 451643)
+++ Makefile	(working copy)
@@ -81,8 +81,7 @@
 		s|%%LOCALBASE%%|${LOCALBASE}|g' \
 		${WRKSRC}/libgnomevfs/xdgmime.c \
 		${WRKSRC}/libgnomevfs/gnome-vfs-hal-mounts.c
-	@${REINPLACE_CMD} -e 's|-lacl||g ; \
-		s|inotify_support=yes|inotify_support=no|g' \
+	@${REINPLACE_CMD} -e 's|-lacl||g' \
 			${WRKSRC}/configure
 	@${REINPLACE_CMD} -e 's|-DG_DISABLE_DEPRECATED||g' \
 		${WRKSRC}/*/Makefile.in

I think it's ok once our libinotify is developed on top on kqueue.
Comment 7 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2018-01-08 01:58:34 UTC 
Created attachment 189498 [details]
gnome-vfs
Comment 8 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2018-01-08 02:02:09 UTC 
Ping...

I'm still having problems with it. The attached patch disables the sys/inotify.h detection, fixing the problem. [1]

I'm depending on this to update x11-fm/gnome-commander2.

I've added LIB_DEPENDS to silence Q/A as well.

[1] /usr/local/lib/gnome-vfs-2.0/modules/libfile.so: Undefined symbol "ih_startup"
Comment 9 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2018-02-13 21:27:48 UTC 
ping...
Comment 10 commit-hook freebsd_committer freebsd_triage 2018-02-19 03:59:50 UTC 
A commit references this bug:

Author: danilo
Date: Mon Feb 19 03:59:26 UTC 2018
New revision: 462273
URL: https://svnweb.freebsd.org/changeset/ports/462273

Log:
  - Completely ignore auto detect of sys/inotify.h
  - Add LIB_DEPENDS to make Q/A happy

  PR:		192724
  Approved by:	maintainer timeout (2+ months)

Changes:
  head/devel/gnome-vfs/Makefile
Comment 11 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2018-02-27 23:11:23 UTC 
Closing.