Bug 192751

Summary: [maintainer update] Improvements for graphics/opennurbs
Product: Ports & Packages Reporter: Fernando Apesteguía <fernape>
Component: Individual Port(s)Assignee: John Marino <marino>
Status: Closed FIXED    
Severity: Affects Some People CC: adamw, marino
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Additional patch none

Description Fernando Apesteguía freebsd_committer freebsd_triage 2014-08-17 16:59:08 UTC 
This patch adds some examples and LICENSE_FILE to the port.

Main credit goes to Marcin Cieslak for his work.

Tested in redports:


[graphics/opennurbs] Adding examples and LICENSE_FILE
---------------------------------------------------------------------

  Build ID:          20140817164900-33784
  Job owner:         fernape
  Buildtime:         4 minutes
  Enddate:           Sun, 17 Aug 2014 16:53:07 GMT

  Revision:          30622
  Repository:        https://redports.org/changeset/30622

---------------------------------------------------------------------

    Port:            graphics/opennurbs 20121024_1

      Buildgroup:     9.2-RELEASE/amd64
      Buildstatus:   SUCCESS
      Log: https://redports.org//~fernape/20140817164900-33784-234961/opennurbs-20121024_1.log

      Buildgroup:     9.2-RELEASE/i386
      Buildstatus:   SUCCESS
      Log: https://redports.org//~fernape/20140817164900-33784-234962/opennurbs-20121024_1.log

      Buildgroup:     10.0-RELEASE/amd64
      Buildstatus:   SUCCESS
      Log: https://redports.org//~fernape/20140817164900-33784-234963/opennurbs-20121024_1.log

      Buildgroup:     10.0-RELEASE/i386
      Buildstatus:   SUCCESS
      Log: https://redports.org//~fernape/20140817164900-33784-234964/opennurbs-20121024_1.log
Comment 1 Adam Weinberger freebsd_committer freebsd_triage 2014-08-23 18:49:27 UTC 
This patch is not against the opennurbs in SVN head. Please regenerate the patch, and attach it to the PR.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2014-08-23 22:01:20 UTC 
Created attachment 146196 [details]
Additional patch
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2014-08-23 22:05:57 UTC 
(In reply to Adam Weinberger from comment #1)
> This patch is not against the opennurbs in SVN head. Please regenerate the
> patch, and attach it to the PR.

Are you sure?

I submitted a new patch, but save by the fact that the path of my svn checkout is different, the patch is the same.

The first one was generated using

diff -ruN /usr/ports/graphics/opennurbs graphics/opennurbs

with /usr/ports being a fresh copy retrieved with portsnap.

and the second one
diff -ruN ~/porting/ports/head/graphics/opennurbs/ graphics/opennurbs/

with a fresh copy checked out with svn.

What am I doing wrong?

Thanks in advance.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-08-24 16:57:43 UTC 
i'll take this on faith.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-08-24 17:12:54 UTC 
The good news: I had no problems applying the patch.

The bad news: All the install commands are masked.  I am going to reveal those.
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-08-24 17:29:17 UTC 
A commit references this bug:

Author: marino
Date: Sun Aug 24 17:28:32 UTC 2014
New revision: 365980
URL: http://svnweb.freebsd.org/changeset/ports/365980

Log:
  graphics/opennurbs: Add license and examples (revbump)

  PR:		192751
  Submitted by:	maintainer (Fernando Apesteguia)

Changes:
  head/graphics/opennurbs/Makefile
  head/graphics/opennurbs/pkg-plist
Comment 7 John Marino freebsd_committer freebsd_triage 2014-08-24 17:30:48 UTC 
I also wrapped all the long lines at 80 columns.  Other than that and the masking, it was fine!
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2014-08-24 18:20:44 UTC 
(In reply to John Marino from comment #7)
> I also wrapped all the long lines at 80 columns.  Other than that and the
> masking, it was fine!

Thanks!

I let Marcin know.