Bug 192871
| Summary: | [stage] databases/xapian-core10 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Chris Hutchinson <portmaster> | ||||
| Component: | Individual Port(s) | Assignee: | John Marino <marino> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | CC: | marino, portmaster | ||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
(In reply to C Hutchinson from comment #0) > Created attachment 146098 [details] > databases/xapian-core10 SVN DIFF -- now it is STAGED > > I was informed that this port was scheduled for removal because it was NOT > STAGED. > I checked out the latest source, and modified it, ran through redports, > all tests passed (FreeBSD versions 8.4 - 11) > the attached file is an svn diff. > > added STAGE > > removed NO_STAGE > > did NOT bump version number. > > Best wishes. > > --Chris Sorry. Forgot to add the redports log(s): https://redports.org/~portmaster/20140821014601-36916-235851/xapian-core10-1.0.23.log https://redports.org/~portmaster/20140821014601-36916-235850/xapian-core10-1.0.23.log https://redports.org/~portmaster/20140821014601-36916-235849/xapian-core10-1.0.23.log https://redports.org/~portmaster/20140821014601-36916-235848/xapian-core10-1.0.23.log patch is very trivial, move to patch-ready fail.
I thought you were going to use poudriere from now on?
===> Cleaning for xapian-core10-1.0.23
=======================<phase: check-sanity >============================
/!\ xapian-core10-1.0.23: Makefile warnings, please consider fixing /!\
MAN1 macros are deprecated when using stage directory
====> Running Q/A tests (stage-qa)
Warning: 'lib/libxapian.so.21' is not stripped consider using ${STRIP_CMD}
Warning: .la libraries found, port needs USES=libtool
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: man/man1/quartzcheck.1.gz
Error: Orphaned: man/man1/quartzcompact.1.gz
Error: Orphaned: man/man1/quartzdump.1.gz
Error: Orphaned: man/man1/xapian-check.1.gz
Error: Orphaned: man/man1/xapian-compact.1.gz
Error: Orphaned: man/man1/xapian-config.1.gz
Error: Orphaned: man/man1/xapian-inspect.1.gz
Error: Orphaned: man/man1/xapian-progsrv.1.gz
Error: Orphaned: man/man1/xapian-tcpsrv.1.gz
===> Checking for directories owned by MTREEs
===> Checking for directories handled by dependencies
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1
At the very, very least you have to try "make check-plist" followed by "make stage-qa" . make check-plist would have failed even on a live system. A commit references this bug: Author: marino Date: Thu Aug 21 10:43:20 UTC 2014 New revision: 365543 URL: http://svnweb.freebsd.org/changeset/ports/365543 Log: Stage databases/xapian-core10 PR: 192871 Submitted by: Chris Hutchinson Overhauled: marino Changes: head/databases/xapian-core10/Makefile head/databases/xapian-core10/pkg-plist The original makefile had a lot of cruft that needed fixing. As the check-qa mentioned, this needed USES=libtool which changed the pkg-plist The libraries also needed to be stripped (fix taken from databases/xapian) I'm sorry to come off harsh, but I'm very experienced yet I always test my patches before handing them over, only on the most trivial do I not do that. and staging is not trivial. (In reply to John Marino from comment #6) > The original makefile had a lot of cruft that needed fixing. > > As the check-qa mentioned, this needed USES=libtool which changed the > pkg-plist > The libraries also needed to be stripped (fix taken from databases/xapian) > > I'm sorry to come off harsh, but I'm very experienced yet I always test my > patches before handing them over, only on the most trivial do I not do that. > and staging is not trivial. No sweat, John. Understood. As to "I thought you were going to use poudriere from now on?" I'm cobbling an 11 box now. RELENG_9 has [for QA on ports] proven to be too old, and I desperately need some dev time with clang. It'll have redports on it as well. Hopefully, that'll come as good news to you. As I fear I've tortured you _far_ too greatly already. Thanks, John. Especially for all your help. --Chris |
Created attachment 146098 [details] databases/xapian-core10 SVN DIFF -- now it is STAGED I was informed that this port was scheduled for removal because it was NOT STAGED. I checked out the latest source, and modified it, ran through redports, all tests passed (FreeBSD versions 8.4 - 11) the attached file is an svn diff. added STAGE removed NO_STAGE did NOT bump version number. Best wishes. --Chris