Bug 192901

Summary: chinese/fcitx: falls stage-qa checks
Product: Ports & Packages Reporter: John Marino <marino>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: lichray
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description John Marino freebsd_committer freebsd_triage 2014-08-21 22:59:41 UTC 
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: @dirrmtry share/cmake
===> Checking for directories owned by MTREEs
pwd
Error: Owned by MTREE: @dirrmtry lib/girepository-1.0
Error: Owned by MTREE: @dirrmtry share/gir-1.0
===> Checking for directories handled by dependencies
Warning: Possibly owned by dependency: @dirrmtry lib/girepository-1.0
Warning: Possibly owned by dependency: @dirrmtry share/gir-1.0
Warning: Possibly owned by dependency: @dirrmtry share/icons/hicolor/scalable/s
Warning: Possibly owned by dependency: @dirrmtry share/icons/hicolor/scalable
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

Stop.
make: stopped in /usr/ports/chinese/fcitx


as a bonus, there's a post-patch target condition for FreeBSD < 8 which can be deleted.  The port could be simplified with OptionsNG
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-21 23:01:03 UTC 
notify maintainer (in CC)
Comment 2 John Marino freebsd_committer freebsd_triage 2014-08-31 10:24:30 UTC 
lichray, ping
Comment 3 John Marino freebsd_committer freebsd_triage 2014-09-09 06:33:06 UTC 
lichray, another ping.

Are you going to look at this port soon?
Comment 4 lichray 2014-09-09 06:39:25 UTC 
(In reply to John Marino from comment #3)
> lichray, another ping.
> 
> Are you going to look at this port soon?

I have no time to do so right now.  If someone want to look at this, he/she can just backports the changes we made here:

  https://github.com/HirotoKagotani/freebsd-fcitx/tree/master/chinese/fcitx

(The repository is a for a new version of fcitx, but we stuck with some dependency issue related to other ports).
Comment 5 John Marino freebsd_committer freebsd_triage 2014-09-09 06:41:44 UTC 
When will you have time?
If we are at the point that others have to maintainer your port, shouldn't we just reset the maintainer to ports@FreeBSD.org?
Comment 6 lichray 2014-09-09 06:44:09 UTC 
(In reply to John Marino from comment #5)
> When will you have time?
> If we are at the point that others have to maintainer your port, shouldn't
> we just reset the maintainer to ports@FreeBSD.org?

If you think that can help anything :)

What's the deadline of the staging change?
Comment 7 John Marino freebsd_committer freebsd_triage 2014-09-09 06:48:14 UTC 
This port is staged, it's just improperly staged.  This is a normal PR, but normally PRs are addressed within a couple of weeks.  Technically this PR is already "timed out" and multiple timeouts is cause for a port reset.

This particular issue isn't about backporting fixes, it's about fixing the pkg-plist so that "make check-plist" passes cleanly.
Comment 8 lichray 2014-09-09 06:55:48 UTC 
(In reply to John Marino from comment #7)
> This port is staged, it's just improperly staged.  This is a normal PR, but
> normally PRs are addressed within a couple of weeks.  Technically this PR is
> already "timed out" and multiple timeouts is cause for a port reset.
> 
> This particular issue isn't about backporting fixes, it's about fixing the
> pkg-plist so that "make check-plist" passes cleanly.

I see.

Please remove the 7 @dirrmtry lines.  They are not in https://github.com/HirotoKagotani/freebsd-fcitx/blob/master/chinese/fcitx/pkg-plist (and I'll remove the share/cmake one from my side).
Comment 9 John Marino freebsd_committer freebsd_triage 2014-09-09 09:01:14 UTC 
It looks like the commit didn't get captured, I added a copy of it below.  share/cmake needs to be added, not removed.  There were more than 7 dirrm lines, and only 4 needed to be removed.

Author: marino
Date: Tue Sep  9 08:49:00 2014
New Revision: 367720
URL: http://svnweb.freebsd.org/changeset/ports/367720
QAT: https://qat.redports.org/buildarchive/r367720/

Log:
  chinese/fcitx: Adjust pkg-plist to pass stage-qa checks
  
  PR:	192901

Modified:
  head/chinese/fcitx/Makefile
  head/chinese/fcitx/pkg-plist

Modified: head/chinese/fcitx/Makefile
==============================================================================
--- head/chinese/fcitx/Makefile	Tue Sep  9 08:45:40 2014	(r367719)
+++ head/chinese/fcitx/Makefile	Tue Sep  9 08:49:00 2014	(r367720)
@@ -3,7 +3,7 @@
 
 PORTNAME=	fcitx
 PORTVERSION=	4.2.6.1
-PORTREVISION=	4
+PORTREVISION=	5
 CATEGORIES=	chinese x11
 MASTER_SITES=	${MASTER_SITE_GOOGLE_CODE}
 DISTFILES=	${DISTNAME}${EXTRACT_SUFX} \

Modified: head/chinese/fcitx/pkg-plist
==============================================================================
--- head/chinese/fcitx/pkg-plist	Tue Sep  9 08:45:40 2014	(r367719)
+++ head/chinese/fcitx/pkg-plist	Tue Sep  9 08:49:00 2014	(r367720)
@@ -368,8 +368,6 @@ share/mime/packages/x-fskin.xml
 @dirrmtry share/icons/gnome/scalable/status
 @dirrmtry share/icons/gnome/scalable
 @dirrmtry share/icons/gnome
-@dirrmtry share/icons/hicolor/scalable/status
-@dirrmtry share/icons/hicolor/scalable
 @dirrmtry %%DATADIR%%/table
 @dirrm %%DATADIR%%/skin/default
 @dirrm %%DATADIR%%/skin/dark
@@ -385,6 +383,7 @@ share/mime/packages/x-fskin.xml
 @dirrm %%DATADIR%%
 %%PORTDOCS%%@dirrm %%DOCSDIR%%
 @dirrm share/cmake/fcitx
+@dirrmtry share/cmake
 @dirrm lib/fcitx
 @dirrm include/fcitx/module/x11
 @dirrm include/fcitx/module/spell
@@ -400,5 +399,3 @@ share/mime/packages/x-fskin.xml
 @dirrm include/fcitx-gclient
 @dirrm include/fcitx-config
 @dirrm include/fcitx
-@dirrmtry lib/girepository-1.0
-@dirrmtry share/gir-1.0