Bug 192903

Summary: [patch] games/xboard: update to new version including Zippy-option etc.
Product: Ports & Packages Reporter: Kalten <kalten>
Component: Individual Port(s)Assignee: Johan van Selst <johans>
Status: Closed Overcome By Events    
Severity: Affects Only Me    
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192669
Attachments:
Description Flags
update from current version (ports v361946) to new version
none
update from current version (ports v361946) to new version Version 2 none

Description Kalten 2014-08-22 01:33:39 UTC
Created attachment 146139 [details]
update from current version (ports v361946) to new version

I happened to find out that there is a more recent version of
games/xboard than that in the ports (4.7.3 from January as v361946 in
the ports tree) at H.G.Muller’s page—namely from July.

I have created a patch (see file patch-v361946-to-newVersion.txt) that
does the following things (and supersedes PR/192669 ¹⁾ as it changes
to a new version and includes zippy):
* PORTVERSION from 4.7.3 to 4.7.3.20140702.2 (it seems not to be 4.7.4
  yet, “20140702.2” means that the git-version is from 2014-07-02 and is
  the third commit on this day—I hope, it will help, so that the ports
  system still knows, which version is the older one by using such a
  system)
* MASTER_SITES is changed to my little server again, as I have saved a
  snapshot (xboard-c591aa5.tar.gz) that is a download form there²⁾
  (I do not have a better solution—same in games/fairymax)
* autogen needed (and called as ${WRKSRC}/autogen.sh in pre-configure
  target) as those generated files are not stored in this git repository
* OPTIONS*
  - Zippy (analogous to PR/192669 ¹⁾)
  - Engins in an OPTIONS_GROUP (none or many)
    including correction of sample configuration file
  - GUI front end in an OPTIONS_SINGLE (exactly one of them to use)
  - Sound output in an OPTIONS_RADIO (none or one)
    including correction of sample configuration file
  And many small changes because of the chosen options.
* Dependencies added
* new distinfo
* git url added to pkg-descr as it is not the git url from the WWW url
  there
* pkg-plist changed (should be OK)
* man-/info-pages tell user where to read about Zippy (zippy.README
  installed to) iff OPTION ZIPPY is selected.
* some files were not installed (sound files and game-configuration
  files) (I shall write H.G.Muller about that—but there is another
  matter in connection to that: could take some time until he will
  change it)

I have invoked ports-mgmt/poudriere using the command “testport”
(everything was OK) testing different combinations of the configuration
options and checking the generated xboard.conf.dist file as well.

And something not that important:
In the post-configure target of the old version some command had been
changed (I have kept it for the new one) but not for all analogous code
fragments (there is a comment in the Makefile now above that target—may
be the maintainer wants to look into that matter)

Well: I hope everything is to everyone’s satisfaction.

ru,
 Kalten

¹⁾ https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192669
²⁾ http://hgm.nubati.net/cgi-bin/gitweb.cgi?p=xboard.git;a=snapshot;h=c591aa5f691ddd2fe00a64993e006d105b47f4a3;sf=tgz
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-22 07:13:15 UTC
over to maintainer
Comment 2 Kalten 2014-08-25 19:25:58 UTC
Created attachment 146262 [details]
update from current version (ports v361946) to new version Version 2
Comment 3 Kalten 2014-08-25 19:27:46 UTC
Hello again!

I have changed some entries in the “pkg-plist” as suggested by »make makeplist«:
* some “@dirrm” -> “@dirrmtry”
* “share/games/xboard/” -> “%%DATADIR%%/”
* “etc/xboard.conf.dist” -> “%%ETCDIR%%.conf.dist”
* “etc/xboard.conf” -> “%%ETCDIR%%.conf”

See new attachment 146262 [details] “patch-v361946-to-newVersion_v2.diff” (replacing old attachment 146139 [details] completely)

Sorry for the late change.
ru,
Kalten
Comment 4 Johan van Selst freebsd_committer freebsd_triage 2014-08-26 10:41:28 UTC
I am no fan of ports using unreleased development versions. Although new features are nice, these packages tend to have untested code and support from upstream authors may be limited, unless you keep updating frequently.

I would be happy to commit this as a separate port, games/xboard-devel, if you are interested in maintaining it. But I'd like to keep games/xboard tracking the official releases.

Note that the zippy option from PR 192669 has been committed to games/xboard.
Comment 5 Kalten 2014-09-03 03:08:36 UTC
(In reply to Johan van Selst from comment #4)
> I am no fan of ports using unreleased development versions. Although new
> features are nice, these packages tend to have untested code and support
> from upstream authors may be limited, unless you keep updating frequently.
> 
> I would be happy to commit this as a separate port, games/xboard-devel, if
> you are interested in maintaining it. But I'd like to keep games/xboard
> tracking the official releases.
I have done this. Pray continue at Bug 193271 and Bug 193272.

Thank you,
 Kalten