Bug 192916

Summary:	too many redirects when downloading an attachment
Product:	Services	Reporter:	Mathieu Arnold <mat>
Component:	Bug Tracker	Assignee:	Bugmeister <bugmeister>
Status:	Closed FIXED
Severity:	Affects Many People	CC:	clusteradm, koobs, peter
Priority:	---
Version:	unspecified
Hardware:	Any
OS:	Any
See Also:	https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192489
Bug Depends on:	204374
Bug Blocks:

Description Mathieu Arnold freebsd_committer

2014-08-22 12:41:14 UTC

When one tries to download an attachment, there is a bit too much redirects going on:

https://bugs.freebsd.org/bugzilla/attachment.cgi?id=146132
redirects to
http://bz-attachments.freebsd.org/attachment.cgi?id=146132
redirects to
https://bz-attachments.FreeBSD.org/attachment.cgi?id=146132

We could do without the one in the middle, I think :-)

Comment 1 Kubilay Kocak freebsd_committer

2014-08-27 11:19:06 UTC

Adding clusteradm@ and linking a possibly related redirect issue

Comment 2 Peter Wemm freebsd_committer

2014-09-13 04:14:31 UTC

I'm not sure how to fix this one.  There is a parameter attachments_base that controls the parallel domain redirection.  The problem is that the bugzilla backend doesn't have the ability to see that a request came in over https.  It always does, but attachments.cgi can't "see" the https part.  It issues another redirect and loops infinitely.

If you are using a browser this isn't normally a big deal because we set strict-transport-security for a long period.  A modern browser won't visit http://bz-attachments more than once per year.  It'll bypass http:// and go direct to https://.

However, fetch(1) doesn't have HSTS persistence and will take the extra detour every time.

Having said that, I haven't given up on it yet.  I just wanted to let you know I have looked at it and its not a simple fix that's obvious to me.

"attachments_base" parameter cannot just be changed.

Comment 3 Marcus von Appen freebsd_committer

2014-09-20 08:29:26 UTC

(In reply to Peter Wemm from comment #2)

> "attachments_base" parameter cannot just be changed.

attachments_base is set to http://bz-attachments.freebsd.org/ at the moment. Would changing it to https://bz-attachments.freebsd.org/ have any other negative impact? Or should we give it a go?

Comment 4 Marcus von Appen freebsd_committer

2014-09-29 21:37:15 UTC

clusteradm@: Can you comment on comment 3?

Comment 5 Peter Wemm freebsd_committer

2014-09-29 23:44:10 UTC

Like I said in comment #2 it doesn't work and I don't yet know how to fix it.  I have tried it, and can conform that it definitely does not work.  It loops infinitely.

Comment 6 Kubilay Kocak freebsd_committer

2016-02-06 13:20:40 UTC

This should now be resolved