Bug 192998

Summary:	lang/ruby19, lang/ruby20, and lang/ruby21 contain obsolete patches that cause warnings
Product:	Ports & Packages	Reporter:	Robert Grimm <rfgrimm>
Component:	Individual Port(s)	Assignee:	freebsd-ruby (Nobody) <ruby>
Status:	Closed FIXED
Severity:	Affects Many People	CC:	swills
Priority:	---
Version:	Latest
Hardware:	Any
OS:	Any

Description Robert Grimm 2014-08-25 22:19:41 UTC

Ruby's lib/uri/generic.rb was patched in SVN commit 236220 to fix a URI handling bug when dealing with FTP relative paths.  This patch is no longer necessary as this bug was fixed in Ruby 1.9.2 and is thus also fixed in Ruby 2.0 and 2.1.  The files/patch-lib_uri_generic.rb files can simply be deleted.

Removing these patches also fixes "/usr/local/lib/ruby/2.1/uri/generic.rb:1493: warning: mismatched indentations at 'end' with 'if' at 1461" warnings that the patches caused.

See https://github.com/ruby/ruby/commit/8588e7631eeab7fe8b91d2f2f7059144b233ad0d for the Ruby commit that fixed the bug that these patches were originally trying to fix.

Comment 1 John Marino freebsd_committer

2014-08-25 22:42:50 UTC

over to ruby team

Comment 2 commit-hook freebsd_committer

2014-09-02 01:14:39 UTC

A commit references this bug:

Author: swills
Date: Tue Sep  2 01:13:48 UTC 2014
New revision: 366970
URL: http://svnweb.freebsd.org/changeset/ports/366970

Log:
  lang/ruby*: remove obsolete patches

  Remove no longer needed patches for ftp.
  While here, fix the test target for ruby21

  PR:		192998
  Submitted by:	Robert Grimm <rfgrimm@gmail.com>

Changes:
  head/Mk/bsd.ruby.mk
  head/lang/ruby19/files/patch-lib_uri_generic.rb
  head/lang/ruby20/files/patch-lib_uri_generic.rb
  head/lang/ruby21/Makefile
  head/lang/ruby21/files/patch-lib_uri_generic.rb

Comment 3 Steve Wills freebsd_committer

2014-09-02 01:15:01 UTC

Fix committed, thanks!