Bug 193012
| Summary: | New port: sysutils/logstash-forwarder | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | cheffo | ||||||||
| Component: | Individual Port(s) | Assignee: | Carlo Strub <cs> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Many People | CC: | cs, marino | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193461 | ||||||||||
| Attachments: |
|
||||||||||
Thanks! Do you have any verification available? In order of preference, examples of what I'm looking for are: 1) "poudriere testport" or "poudriere bulk -t" logs 2) Redports or tinderbox logs 3) "make check-plist" followed by "make stage-qa" output (https://www.freebsd.org/doc/en/books/porters-handbook/porting-testing.html) It looks ok though. verification would confirm. Created attachment 146311 [details]
poudriere testport -o local/logstash-forwarder -j 10amd64 output
BUILD_DEPENDS= go:${PORTSDIR}/lang/go (missing tab)
My custom ports are in local/ and poudriere testport complains but it should be OK if put in the proper (sysutils) folder.
can you clean up the fatal portlint error? (new shar) FATAL: Makefile: [12]: use a tab (not space) after a variable name then I'll move it to match ready Created attachment 146317 [details]
Shar archive
Fixed tab.
ok, moving to patch-ready A commit references this bug: Author: cs Date: Fri Sep 5 20:50:49 UTC 2014 New revision: 367389 URL: http://svnweb.freebsd.org/changeset/ports/367389 Log: I'm a lumberjack and I'm ok! I sleep when idle, then I ship logs all day! I parse your logs, I eat the JVM agent for lunch! (This project was recently renamed from 'lumberjack' to 'logstash-forwarder' to make its intended use clear. The 'lumberjack' name now remains as the network protocol, and 'logstash-forwarder' is the name of the program. It's still the same lovely log forwarding program you love.) WWW: https://github.com/elasticsearch/logstash-forwarder PR: ports/193012 Submitted by: cheffo@freebsd-bg.org Changes: head/sysutils/Makefile head/sysutils/logstash-forwarder/ head/sysutils/logstash-forwarder/Makefile head/sysutils/logstash-forwarder/distinfo head/sysutils/logstash-forwarder/files/ head/sysutils/logstash-forwarder/files/logstash-forwarder.in head/sysutils/logstash-forwarder/files/patch-fileinfo_freebsd.go head/sysutils/logstash-forwarder/files/patch-filestate_freebsd.go head/sysutils/logstash-forwarder/files/pkg-message.in head/sysutils/logstash-forwarder/pkg-descr head/sysutils/logstash-forwarder/pkg-plist A commit references this bug: Author: cs Date: Fri Sep 5 20:55:52 UTC 2014 New revision: 45549 URL: http://svnweb.freebsd.org/changeset/doc/45549 Log: Add new contributor PR: 193012 Changes: head/en_US.ISO8859-1/articles/contributors/contrib.additional.xml Committed with some reservations:
It is urgent that you use:
.include "${PORTSDIR}/lang/go/files/bsd.go.mk"
next time you update this port, because there is a high chance that this will be moved into Mk at some point and therefore your port will already follow the standards for go ports.
(In reply to Carlo Strub from comment #8) > Committed with some reservations: > > It is urgent that you use: > > .include "${PORTSDIR}/lang/go/files/bsd.go.mk" > Carlo, this is semi-bad advice. Don't use "${PORTSDIR}" ever, use "${.CURDIR}/../.." instead Hmm. I didn't know about that John. Thanks for updating me on this. Cheers, Carlo I'm fixing the port to use .include "${.CURDIR}/../../lang/go/files/bsd.go.mk"
and will also update it as there is an update from upstream. Should I fill new bug report or reuse this one?
Thanks.
Please re-use this one. Disregard. I see the port was already committed and there's already another PR. And the PR is closed. So ignore what I just said. |
Created attachment 146303 [details] Shar archive portlint output: looks fine.