Bug 193085
| Summary: | [stage] dns/dnscheckengine: add stage support and request maintainership | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Chris Hutchinson <portmaster> |
| Component: | Individual Port(s) | Assignee: | John Marino <marino> |
| Status: | Closed FIXED | ||
| Severity: | Affects Many People | CC: | marino, portmaster |
| Priority: | --- | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
| Attachments: | |||
Created attachment 146427 [details]
dns/dnscheckengine build stage session
The attached; dns-dnscheckengine-out
is simply the output of the build stage clean session.
--Chris
you know I need to see poudriere logs. redports logs are nice but insufficient for staging. This is not ready.
For example "@${INSTALL_DATA} ${DOCS:S|^|${WRKSRC}/doc/|} ${STAGEDIR}${DOCSDIR}"
The "@" masks the command. This is not allowed in install targets. (Remove the "@" on every command except maybe $MKDIR commands)
Worse (and hard to believe since I knocked on this a few days ago), none of the man pages are staged.
MAN1 and MAN3 are defined in makefile and not defined in pkg-plist.
This one is not close at all.
(In reply to John Marino from comment #3) > This is not ready. > > For example "@${INSTALL_DATA} ${DOCS:S|^|${WRKSRC}/doc/|} > ${STAGEDIR}${DOCSDIR}" > > The "@" masks the command. This is not allowed in install targets. (Remove > the "@" on every command except maybe $MKDIR commands) > > > Worse (and hard to believe since I knocked on this a few days ago), none of > the man pages are staged. > > MAN1 and MAN3 are defined in makefile and not defined in pkg-plist. > > > This one is not close at all. Thanks, and sorry. I'll run it through poudriere, and fix it as required -- complete with logs/reports. --Chris Created attachment 146893 [details]
dns/dnscheckengine [request maintainer] STAGE LICENSE ... with QA log
dns/dnscheckengine
adds STAGEDIR, LICENSE, MAINTAINER
modifies pkg-plist
includes requisite QA log (dns-dnscheckengine-output), also attached
See 2014-09-05.diff, attached.
--Chris
Created attachment 146895 [details]
dns/dnscheckengine - QA log for 2014-09-05.diff, also attached
dns/dnscheckengine
Requisite QA log (dns-dnscheckengine-output), attached.
Please see 2014-09-05.diff, also attached.
--Chris
everything looks ok except I recommend new lines 52-55 be deleted. I don't see what purpose they serve. Created attachment 147063 [details]
dns/dnscheckengine STAGE cleanup
dns/dnscheckengine
Adds nothing to previous diff.
Removes unnecessary lines, as per JM. :)
Please find 2014-09-07.diff, attached.
Thanks.
FWIW MANCOMPRESSED does work. But turns out, not as documented. :)
--Chris
I'm making several tweaks, but I did notice ALL the post-install commands are masked. I know they were masked before, but it is correct to fix them now. 1) the TMPPLIST line (from before) is absurd, that needs to be in pkg-plist. 2) the POST-INSTALL line is obsolete now, it should have been deleted I suspect the MYSQL option wasn't tested, it doesn't look like it will pass check-plist to me (but untested) You have pkg-message in SUB_FILES, and later in post-install you are SED'ing pkg-message which should be entirely doing nothing (should be removed) MYSQL is not optional, look at this failed log: ===> Configuring for dnscheckengine-1.1_2 Warning: prerequisite DBD::mysql 0 not found. Warning: prerequisite DBI 0 not found. Warning: prerequisite Net::IP 1.25 not found. Checking if your kit is complete... Looks good The Makefile.PL says the same that, it DBI mysql is expected. There also seems to be a missing dependency. I have to remove the MYSQL option and make it required. Otherwise it will build differently depending on what is on the live system. I am going to remove pkg-install and pkg-deinstall. It seems these were created to stop the daemon. It's not necessary, plus it's failing plist-check and it's more complex. Let's make this simpler. Your ${LN} -s line is wrong. It's linking back to ${STAGEDIR} instead of where the file is supposed to be installed. Look at that line, it should be obvious what's wrong if you think about it.
A commit references this bug: Author: marino Date: Mon Sep 8 22:34:58 UTC 2014 New revision: 367708 URL: http://svnweb.freebsd.org/changeset/ports/367708 Log: Stage dns/dnscheckengine and assign maintainership to submitter PR: 193085 Submitted by: Chris Hutchinson Reworked by: marino Changes: head/dns/dnscheckengine/Makefile head/dns/dnscheckengine/files/pkg-deinstall.in head/dns/dnscheckengine/files/pkg-install.in head/dns/dnscheckengine/pkg-descr head/dns/dnscheckengine/pkg-plist All your notes above are, of course, are correct. Let me try, and clean this up myself. I hate that you're laboring over stuff _I_ should be doing, myself. I'm a big enough pain, as it is. Without you're doing my work for me. I'll never get this stuff right, if I don't work through it myself. But I _do_ appreciate your pointers. :) That includes ones I don't like hearing, too. ;) Thanks, John! --Chris OOPS! I had a mid-air-collision. Looks like I spoke too late. :( Thanks, a million, John. I'll take a close look at your changes. For my future work. So you don't have to continue doing this sort of thing. Thanks again, John, and sorry for the bother. --Chris Just took a look at your wrok. Looks beautiful! Can't wait till I start producing stuff more like that. :) Thanks again! --Chris This was another "famous" Hutchinson PR though. I had to do a lot of iterations. I don't have poudriere handy atm (I'm in a hotel) but it passed redports in the end. Anyway, I hoped it would be quick but it wasn't. Most of that wasn't the staging work, the original port was bad. |
Created attachment 146426 [details] [maintainer] STAGE LICENSE svn diff dns/dnscheckengine ADDED MAINTAINER LICENSE STAGE see svn diff, attached see also dns-dnscheckengine-out -- make stage deinstall clean session Thank you for all your time, and consideration. --Chris